From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/rsrc: avoid NULL check in io_put_rsrc_node()
Date: Mon, 17 Feb 2025 05:46:07 -0700 [thread overview]
Message-ID: <173979636710.644986.8096661613228249151.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250216225900.1075446-1-csander@purestorage.com>
On Sun, 16 Feb 2025 15:58:59 -0700, Caleb Sander Mateos wrote:
> Most callers of io_put_rsrc_node() already check that node is non-NULL:
> - io_rsrc_data_free()
> - io_sqe_buffer_register()
> - io_reset_rsrc_node()
> - io_req_put_rsrc_nodes() (REQ_F_BUF_NODE indicates non-NULL buf_node)
>
> Only io_splice_cleanup() can call io_put_rsrc_node() with a NULL node.
> So move the NULL check there.
>
> [...]
Applied, thanks!
[1/1] io_uring/rsrc: avoid NULL check in io_put_rsrc_node()
commit: 496f56bf9f1acf11ce14489f34d81ba6e4023f42
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-02-17 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 22:58 [PATCH] io_uring/rsrc: avoid NULL check in io_put_rsrc_node() Caleb Sander Mateos
2025-02-17 12:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173979636710.644986.8096661613228249151.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox