Linux io-uring development
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Josef <josef.grieb@gmail.com>,
	io-uring <io-uring@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: norman@apache.org
Subject: Re: Using SQPOLL for-5.11/io_uring kernel NULL pointer dereference
Date: Sat, 7 Nov 2020 20:03:08 +0000	[thread overview]
Message-ID: <1a4e38df-d977-abea-e6b8-b64f436c81a5@gmail.com> (raw)
In-Reply-To: <69f14eaa-b75d-8f7b-3897-1f47bb2e325b@gmail.com>

On 07/11/2020 16:28, Pavel Begunkov wrote:
> On 07/11/2020 14:09, Josef wrote:
>>> I haven't got the first email, is it "kernel NULL pointer dereference"
>>> as in the subject or just freeze?
>>
>> that's weird..probably the size of the attached log file is too big...
>> here dmesg log file
>> https://gist.github.com/1Jo1/3d0bcefc18f097265f0dc1ef054a87c0
> 
> That's much better with the log, thanks! I'll take a look later

Ok, we get into fget_many() without ->files, and it's clear how it
may happen. I'll write up a patch.

> 
>>
>>> - did you locate which test hangs it? If so what it uses? e.g. SQPOLL
>>> sharing, IOPOLL., etc.
>>
>> yes, it uses SQPOLL, without sharing, IPOLL is not enabled, and Async
>> Flag is enabled
>>
>>> - is it send/recvmsg, send/recv you use? any other?
>>
>> no the tests which occurs the error use these operations: OP_READ,
>> OP_WRITE, OP_POLL_ADD, OP_POLL_REMOVE, OP_CLOSE, OP_ACCEPT, OP_TIMEOUT
>> (OP_READ, OP_WRITE and OP_CLOSE async flag is enabled)
>>
>>> - does this happen often?
>>
>> yeah quite often
>>
>>> - you may try `funcgraph __io_sq_thread -H` or even with `io_sq_thread`
>>> (funcgraph is from bpftools). Or catch that with some other tools.
>>
>> I'm not quite familiar with these tools( kernel debugging in general)
>> I'll take a look tomorrow
> 

-- 
Pavel Begunkov

      reply	other threads:[~2020-11-07 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAss7+pgQN7uPFaLakd+K4yZH6TRcMHELQV0wAA2NUxPpYEL_Q@mail.gmail.com>
2020-11-07  0:51 ` Using SQPOLL for-5.11/io_uring kernel NULL pointer dereference Josef
2020-11-07 12:10   ` Pavel Begunkov
2020-11-07 14:09     ` Josef
2020-11-07 16:28       ` Pavel Begunkov
2020-11-07 20:03         ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a4e38df-d977-abea-e6b8-b64f436c81a5@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=josef.grieb@gmail.com \
    --cc=norman@apache.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox