Re: [PATCH 1/1] io_uring: regbuf vector size truncation

[Pavel Begunkov <asml.silence@gmail.com>]

On 11/7/25 21:14, Günther Noack wrote:
...>> @@ -1512,7 +1515,11 @@ int io_import_reg_vec(int ddir, struct iov_iter *iter,
>>   		if (unlikely(ret))
>>   			return ret;
>>   	} else {
>> -		nr_segs = io_estimate_bvec_size(iov, nr_iovs, imu);
>> +		int ret = io_estimate_bvec_size(iov, nr_iovs, imu);
>> +
>> +		if (ret < 0)
>> +			return ret;
>> +		nr_segs = ret;
>>   	}
>>   
>>   	if (sizeof(struct bio_vec) > sizeof(struct iovec)) {
>> -- 
>> 2.49.0
>>
> 
> I reviewed the logic and the check looks correct,
> and I tested that it works as expected.
> 
> (Minor remark: You might want to annotate the conditions as unlikely()?)

FWIW, it doesn't really matter here, the check can be optimised
out by moving more of the sanitisation logic earlier, but that's
for later.

> Reviewed-by: Günther Noack <gnoack@google.com>
> Tested-by: Günther Noack <gnoack@google.com>

Great, thanks

-- 
Pavel Begunkov