Re: [PATCH 1/2] fs: Abstract calling the kiocb completion function

Jens Axboe
2020-07-08T22:37:28Z

On 7/8/20 4:26 PM, Matthew Wilcox (Oracle) wrote:
> diff --git a/crypto/af_alg.c b/crypto/af_alg.c
> index b1cd3535c525..590dbbcd0e9f 100644
> --- a/crypto/af_alg.c
> +++ b/crypto/af_alg.c
> @@ -1045,7 +1045,7 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err)
> af_alg_free_resources(areq);
> sock_put(sk);
>
> - iocb->ki_complete(iocb, err ? err : (int)resultlen, 0);
> + complete_kiocb(iocb, err ? err : (int)resultlen, 0);

I'd prefer having it called kiocb_complete(), seems more in line with
what you'd expect in terms of naming for an exported interface.

--
Jens Axboe