Re: [PATCH 5/9] fs: remove various compat readv/writev helpers

Al Viro
2020-09-23T14:25:59Z

On Wed, Sep 23, 2020 at 08:05:43AM +0200, Christoph Hellwig wrote:
> COMPAT_SYSCALL_DEFINE3(readv, compat_ulong_t, fd,
> - const struct compat_iovec __user *,vec,
> + const struct iovec __user *, vec,

Um... Will it even compile?

> #ifdef __ARCH_WANT_COMPAT_SYS_PREADV64
> COMPAT_SYSCALL_DEFINE4(preadv64, unsigned long, fd,
> - const struct compat_iovec __user *,vec,
> + const struct iovec __user *, vec,

Ditto. Look into include/linux/compat.h and you'll see

asmlinkage long compat_sys_preadv64(unsigned long fd,
const struct compat_iovec __user *vec,
unsigned long vlen, loff_t pos);

How does that manage to avoid the compiler screaming bloody
murder?