Re: [PATCH v1 0/5] io_uring: add xattr support

Christian Brauner
2021-12-01T13:14:34Z

On Wed, Dec 01, 2021 at 01:46:21AM -0600, Clay Harris wrote:
> On Tue, Nov 30 2021 at 22:07:47 -0800, Stefan Roesch quoth thus:
>
> >
> >
> > On 11/29/21 5:08 PM, Clay Harris wrote:
> > > On Mon, Nov 29 2021 at 14:12:52 -0800, Stefan Roesch quoth thus:
> > >
> > >> This adds the xattr support to io_uring. The intent is to have a more
> > >> complete support for file operations in io_uring.
> > >>
> > >> This change adds support for the following functions to io_uring:
> > >> - fgetxattr
> > >> - fsetxattr
> > >> - getxattr
> > >> - setxattr
> > >
> > > You may wish to consider the following.
> > >
> > > Patching for these functions makes for an excellent opportunity
> > > to provide a better interface. Rather than implement fXetattr
> > > at all, you could enable io_uring to use functions like:
> > >
> > > int Xetxattr(int dfd, const char *path, const char *name,
> > > [const] void *value, size_t size, int flags);
> > >
> > > Not only does this simplify the io_uring interface down to two
> > > functions, but modernizes and fixes a deficit in usability.
> > > In terms of io_uring, this is just changing internal interfaces.
> > >
> > > Although unnecessary for io_uring, it would be nice to at least
> > > consider what parts of this code could be leveraged for future
> > > Xetxattr2 syscalls.
> >
>
> I may have become a little over-excited when I saw someone was thinking
> about new code associated with these interfaces. It's just that, to be
> very kind, the existing interfaces have so much room for improvement.
> I'm aware that changes in this area can be a non-trivial amount of
> work, due to specific xattr keys being handled by different security
> module hooks.
>
> > Clay,
> >
> > while we can reduce the number of calls to 2, providing 4 calls will
> > ease the adoption of the interface.
>
> Well, there's removexattr(), but who's counting?
> I believe people use the other *at() interfaces without ever looking
> back at the old calls and that there is little point in io_uring reproducing
> all of the old baggage.
>
> > If you look at the userspace interface in liburing, you can see the
> > following function signature:
> >
> > static inline void io_uring_prep_fgetxattr(struct io_uring_sqe *sqe,
> > int fd,
> > const char *name,
> > const char *value,
> > size_t len)
> >
> > This is very similar to what you proposed.
>
> Even though these functions desperately need updating, and as super nice

This code could use some serious cleanup as it is super hard to follow
right now imho. It often gives the impression of forming loops when
following callchains down into the filesystem. None of this is by
design of course. I just happened to grow that way, I guess.
However, for maintenance this is quite painful. I also don't like that
the relationship between xattr and acls and the .set_acl inode methods
is rather opaque in the code. I have a vague plan to cleanup some of
that since I had to mess with this code not too long ago.
But that'll be a bigger chunk of work.

Christian