Re: [PATCH 11/17] block: factor out helper for bio allocation from cache

Kanchan Joshi
2022-03-10T12:25:31Z

On Thu, Mar 10, 2022 at 2:05 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Mar 08, 2022 at 08:50:59PM +0530, Kanchan Joshi wrote:
> > +struct bio *bio_alloc_kiocb(struct kiocb *kiocb, unsigned short nr_vecs,
> > + struct bio_set *bs)
> > +{
> > + if (!(kiocb->ki_flags & IOCB_ALLOC_CACHE))
> > + return bio_alloc_bioset(GFP_KERNEL, nr_vecs, bs);
> > +
> > + return bio_from_cache(nr_vecs, bs);
> > +}
> > EXPORT_SYMBOL_GPL(bio_alloc_kiocb);
>
> If we go down this route we might want to just kill the bio_alloc_kiocb
> wrapper.

Fine, will kill that in v2.