Re: [PATCH 2/6] io_uring: serialize ctx->rings->sq_flags with atomic_or/and

Jens Axboe
2022-04-26T15:33:00Z

On 4/26/22 9:03 AM, Almog Khaikin wrote:
> On 4/26/22 04:49, Jens Axboe wrote:
>> Rather than require ctx->completion_lock for ensuring that we don't
>> clobber the flags, use the atomic bitop helpers instead. This removes
>> the need to grab the completion_lock, in preparation for needing to set
>> or clear sq_flags when we don't know the status of this lock.
>
> The smp_mb() in io_sq_thread() should also be changed to
> smp_mb__after_atomic()

Indeed, want to send a patch?

--
Jens Axboe