public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, asml.silence@gmail.com,
	joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: [PATCH for-next 0/4] nvme-multipathing for uring-passthrough
Date: Mon, 11 Jul 2022 16:31:51 +0530	[thread overview]
Message-ID: <20220711110155.649153-1-joshi.k@samsung.com> (raw)
In-Reply-To: CGME20220711110753epcas5p4169b9e288d15ca35740dbb66a6f6983a@epcas5p4.samsung.com

nvme passthrough lacks multipathing capability and some of us have
already expressed interest to see this plumbed. Most recently during LSFMM,
around 2 months back.

This series wires up multipathing for uring-passthrough commands.
Attempt is not to affect the common path (i.e. when
requeue/failover does not trigger) with allocation or deferral. The
most important design bit is to treat "struct io_uring_cmd" in the same
way as "struct bio" is treated by the block-based nvme multipath.
Uring-commands are queued when path is not available, and resubmitted on
discovery of new path. Also if passthrough command on multipath-node is
failed, it is resubmitted on a different path.

Testing:
Using the upstream fio that support uring-passthrough:

fio -iodepth=16 -rw=randread -ioengine=io_uring_cmd -bs=4k -numjobs=4
-size=1G -iodepth_batch_submit=16 -group_reporting -cmd_type=nvme
-filename=/dev/ng0n1 -name=uring-pt

1. Multiple failover - every command is retried 1-5 times before completion
2. Fail nvme_find_path() - this tests completion post requeue
3. Combine above two
4. Repeat above but for passthrough commands which do not generate bio
(e.g. flush command)


Anuj Gupta (2):
  nvme: compact nvme_uring_cmd_pdu struct
  nvme-multipath: add multipathing for uring-passthrough commands

Kanchan Joshi (2):
  io_uring, nvme: rename a function
  io_uring: grow a field in struct io_uring_cmd

 drivers/nvme/host/ioctl.c     | 157 +++++++++++++++++++++++++++++-----
 drivers/nvme/host/multipath.c |  36 +++++++-
 drivers/nvme/host/nvme.h      |  26 ++++++
 include/linux/io_uring.h      |  44 +++++++++-
 io_uring/uring_cmd.c          |   4 +-
 5 files changed, 237 insertions(+), 30 deletions(-)

-- 
2.25.1


       reply	other threads:[~2022-07-11 11:28 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220711110753epcas5p4169b9e288d15ca35740dbb66a6f6983a@epcas5p4.samsung.com>
2022-07-11 11:01 ` Kanchan Joshi [this message]
2022-07-11 11:01   ` [PATCH for-next 1/4] io_uring, nvme: rename a function Kanchan Joshi
2022-07-14 13:55     ` Ming Lei
2022-07-11 11:01   ` [PATCH for-next 2/4] nvme: compact nvme_uring_cmd_pdu struct Kanchan Joshi
2022-07-12  6:32     ` Christoph Hellwig
2022-07-11 11:01   ` [PATCH for-next 3/4] io_uring: grow a field in struct io_uring_cmd Kanchan Joshi
2022-07-11 17:00     ` Sagi Grimberg
2022-07-11 17:19       ` Jens Axboe
2022-07-11 17:18     ` Jens Axboe
2022-07-11 17:55       ` Sagi Grimberg
2022-07-11 18:22         ` Sagi Grimberg
2022-07-11 18:24           ` Jens Axboe
2022-07-11 18:58             ` Sagi Grimberg
2022-07-12 11:40             ` Kanchan Joshi
2022-07-14  3:40           ` Ming Lei
2022-07-14  8:19             ` Kanchan Joshi
2022-07-14 15:30               ` Daniel Wagner
2022-07-15 11:07                 ` Kanchan Joshi
2022-07-18  9:03                   ` Daniel Wagner
2022-07-11 11:01   ` [PATCH for-next 4/4] nvme-multipath: add multipathing for uring-passthrough commands Kanchan Joshi
2022-07-11 13:51     ` Sagi Grimberg
2022-07-11 15:12       ` Stefan Metzmacher
2022-07-11 16:58         ` Sagi Grimberg
2022-07-11 18:54         ` Kanchan Joshi
2022-07-11 18:37       ` Kanchan Joshi
2022-07-11 19:56         ` Sagi Grimberg
2022-07-12  4:23           ` Kanchan Joshi
2022-07-12 21:26             ` Sagi Grimberg
2022-07-13  5:37               ` Kanchan Joshi
2022-07-13  9:03                 ` Sagi Grimberg
2022-07-13 11:28                   ` Kanchan Joshi
2022-07-13 12:17                     ` Sagi Grimberg
2022-07-14 15:14                 ` Ming Lei
2022-07-14 23:05                   ` Kanchan Joshi
2022-07-15  1:35                     ` Ming Lei
2022-07-15  1:46                       ` Ming Lei
2022-07-15  4:24                         ` Kanchan Joshi
2022-07-12  6:52     ` Christoph Hellwig
2022-07-12 11:33       ` Kanchan Joshi
2022-07-12 20:13       ` Sagi Grimberg
2022-07-13  5:36         ` Christoph Hellwig
2022-07-13  8:04           ` Sagi Grimberg
2022-07-13 10:12             ` Christoph Hellwig
2022-07-13 11:00               ` Sagi Grimberg
2022-07-13 11:28                 ` Christoph Hellwig
2022-07-13 12:16                   ` Sagi Grimberg
2022-07-13 11:49                 ` Hannes Reinecke
2022-07-13 12:43                   ` Sagi Grimberg
2022-07-13 13:30                     ` Hannes Reinecke
2022-07-13 13:41                       ` Sagi Grimberg
2022-07-13 14:07                         ` Hannes Reinecke
2022-07-13 15:59                           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711110155.649153-1-joshi.k@samsung.com \
    --to=joshi.k@samsung.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=joshiiitr@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox