public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, asml.silence@gmail.com,
	joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: [PATCH for-next 3/4] io_uring: grow a field in struct io_uring_cmd
Date: Mon, 11 Jul 2022 16:31:54 +0530	[thread overview]
Message-ID: <20220711110155.649153-4-joshi.k@samsung.com> (raw)
In-Reply-To: <20220711110155.649153-1-joshi.k@samsung.com>

Use the leftover space to carve 'next' field that enables linking of
io_uring_cmd structs. Also introduce a list head and few helpers.

This is in preparation to support nvme-mulitpath, allowing multiple
uring passthrough commands to be queued.

Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
---
 include/linux/io_uring.h | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h
index 54063d67506b..d734599cbcd7 100644
--- a/include/linux/io_uring.h
+++ b/include/linux/io_uring.h
@@ -22,9 +22,14 @@ struct io_uring_cmd {
 	const void	*cmd;
 	/* callback to defer completions to task context */
 	void (*task_work_cb)(struct io_uring_cmd *cmd);
+	struct io_uring_cmd	*next;
 	u32		cmd_op;
-	u32		pad;
-	u8		pdu[32]; /* available inline for free use */
+	u8		pdu[28]; /* available inline for free use */
+};
+
+struct ioucmd_list {
+	struct io_uring_cmd *head;
+	struct io_uring_cmd *tail;
 };
 
 #if defined(CONFIG_IO_URING)
@@ -54,6 +59,27 @@ static inline void io_uring_free(struct task_struct *tsk)
 	if (tsk->io_uring)
 		__io_uring_free(tsk);
 }
+
+static inline struct io_uring_cmd *ioucmd_list_get(struct ioucmd_list *il)
+{
+	struct io_uring_cmd *ioucmd = il->head;
+
+	il->head = il->tail = NULL;
+
+	return ioucmd;
+}
+
+static inline void ioucmd_list_add(struct ioucmd_list *il,
+		struct io_uring_cmd *ioucmd)
+{
+	ioucmd->next = NULL;
+
+	if (il->tail)
+		il->tail->next = ioucmd;
+	else
+		il->head = ioucmd;
+	il->tail = ioucmd;
+}
 #else
 static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
 		ssize_t ret2)
@@ -80,6 +106,14 @@ static inline const char *io_uring_get_opcode(u8 opcode)
 {
 	return "";
 }
+static inline struct io_uring_cmd *ioucmd_list_get(struct ioucmd_list *il)
+{
+	return NULL;
+}
+static inline void ioucmd_list_add(struct ioucmd_list *il,
+		struct io_uring_cmd *ioucmd)
+{
+}
 #endif
 
 #endif
-- 
2.25.1


  parent reply	other threads:[~2022-07-11 11:28 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220711110753epcas5p4169b9e288d15ca35740dbb66a6f6983a@epcas5p4.samsung.com>
2022-07-11 11:01 ` [PATCH for-next 0/4] nvme-multipathing for uring-passthrough Kanchan Joshi
2022-07-11 11:01   ` [PATCH for-next 1/4] io_uring, nvme: rename a function Kanchan Joshi
2022-07-14 13:55     ` Ming Lei
2022-07-11 11:01   ` [PATCH for-next 2/4] nvme: compact nvme_uring_cmd_pdu struct Kanchan Joshi
2022-07-12  6:32     ` Christoph Hellwig
2022-07-11 11:01   ` Kanchan Joshi [this message]
2022-07-11 17:00     ` [PATCH for-next 3/4] io_uring: grow a field in struct io_uring_cmd Sagi Grimberg
2022-07-11 17:19       ` Jens Axboe
2022-07-11 17:18     ` Jens Axboe
2022-07-11 17:55       ` Sagi Grimberg
2022-07-11 18:22         ` Sagi Grimberg
2022-07-11 18:24           ` Jens Axboe
2022-07-11 18:58             ` Sagi Grimberg
2022-07-12 11:40             ` Kanchan Joshi
2022-07-14  3:40           ` Ming Lei
2022-07-14  8:19             ` Kanchan Joshi
2022-07-14 15:30               ` Daniel Wagner
2022-07-15 11:07                 ` Kanchan Joshi
2022-07-18  9:03                   ` Daniel Wagner
2022-07-11 11:01   ` [PATCH for-next 4/4] nvme-multipath: add multipathing for uring-passthrough commands Kanchan Joshi
2022-07-11 13:51     ` Sagi Grimberg
2022-07-11 15:12       ` Stefan Metzmacher
2022-07-11 16:58         ` Sagi Grimberg
2022-07-11 18:54         ` Kanchan Joshi
2022-07-11 18:37       ` Kanchan Joshi
2022-07-11 19:56         ` Sagi Grimberg
2022-07-12  4:23           ` Kanchan Joshi
2022-07-12 21:26             ` Sagi Grimberg
2022-07-13  5:37               ` Kanchan Joshi
2022-07-13  9:03                 ` Sagi Grimberg
2022-07-13 11:28                   ` Kanchan Joshi
2022-07-13 12:17                     ` Sagi Grimberg
2022-07-14 15:14                 ` Ming Lei
2022-07-14 23:05                   ` Kanchan Joshi
2022-07-15  1:35                     ` Ming Lei
2022-07-15  1:46                       ` Ming Lei
2022-07-15  4:24                         ` Kanchan Joshi
2022-07-12  6:52     ` Christoph Hellwig
2022-07-12 11:33       ` Kanchan Joshi
2022-07-12 20:13       ` Sagi Grimberg
2022-07-13  5:36         ` Christoph Hellwig
2022-07-13  8:04           ` Sagi Grimberg
2022-07-13 10:12             ` Christoph Hellwig
2022-07-13 11:00               ` Sagi Grimberg
2022-07-13 11:28                 ` Christoph Hellwig
2022-07-13 12:16                   ` Sagi Grimberg
2022-07-13 11:49                 ` Hannes Reinecke
2022-07-13 12:43                   ` Sagi Grimberg
2022-07-13 13:30                     ` Hannes Reinecke
2022-07-13 13:41                       ` Sagi Grimberg
2022-07-13 14:07                         ` Hannes Reinecke
2022-07-13 15:59                           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711110155.649153-4-joshi.k@samsung.com \
    --to=joshi.k@samsung.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=joshiiitr@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox