From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, io-uring@vger.kernel.org
Subject: Re: __io_file_supports_nowait for regular files
Date: Thu, 21 Jul 2022 18:23:03 +0200 [thread overview]
Message-ID: <20220721162303.GA9289@lst.de> (raw)
In-Reply-To: <62207ded-7bf8-9aa1-bfc0-90a0aa12c373@kernel.dk>
On Thu, Jul 21, 2022 at 09:59:40AM -0600, Jens Axboe wrote:
> On 7/21/22 9:37 AM, Christoph Hellwig wrote:
> > Hi Jens,
> >
> > is there any good reason __io_file_supports_nowait checks the
> > blk_queue_nowait flag for regular files? The FMODE_NOWAIT is set
> > for regular files that support nowait I/O, and should be all that
> > is needed. Even with a block device that does not nonblocking
> > I/O some thing like reading from the page cache can be done
> > non-blocking.
>
> Nope, we can probably kill that check then. Want to send a patch?
What would be a good way to verify it doesn't break any strange
assumptions? I kinda don't fell too comfortable touching io_uring
guts.
>
> --
> Jens Axboe
---end quoted text---
next prev parent reply other threads:[~2022-07-21 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:37 __io_file_supports_nowait for regular files Christoph Hellwig
2022-07-21 15:59 ` Jens Axboe
2022-07-21 16:23 ` Christoph Hellwig [this message]
2022-07-21 18:46 ` Jens Axboe
2022-07-22 15:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721162303.GA9289@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox