From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org
Subject: Re: [PATCH] [RFC]: fs: claw back a few FMODE_* bits
Date: Thu, 28 Mar 2024 06:36:31 +0100 [thread overview]
Message-ID: <20240328053631.GB15831@lst.de> (raw)
In-Reply-To: <ZgTFTu8byn0fg9Ld@dread.disaster.area>
On Thu, Mar 28, 2024 at 12:18:06PM +1100, Dave Chinner wrote:
> > if (!(kiocb->ki_flags & IOCB_DIRECT) &&
> > - !(kiocb->ki_filp->f_mode & FMODE_BUF_WASYNC) &&
> > + !fops_buf_wasync(kiocb->ki_filp) &&
> > (req->flags & REQ_F_ISREG))
> > goto copy_iov;
>
> You should probably also fix that comment - WASYNC is set when the
> filesystem supports NOWAIT for buffered writes.
The existing indentation is also horribly wrong here, might be owrth
fixing if we touch it anyway..
next prev parent reply other threads:[~2024-03-28 5:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:45 [PATCH] [RFC]: fs: claw back a few FMODE_* bits Christian Brauner
2024-03-27 17:19 ` Jens Axboe
2024-03-28 9:40 ` Christian Brauner
2024-03-28 1:18 ` Dave Chinner
2024-03-28 5:36 ` Christoph Hellwig [this message]
2024-03-28 8:06 ` Christian Brauner
2024-03-28 8:13 ` Christoph Hellwig
2024-03-28 9:41 ` Christian Brauner
2024-04-01 23:16 ` Dave Chinner
2024-03-28 5:35 ` Christoph Hellwig
2024-03-28 9:29 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328053631.GB15831@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox