Re: [PATCHv12 00/12] block write streams with nvme fdp

Keith Busch
2024-12-09T16:07:38Z

On Mon, Dec 09, 2024 at 01:55:11PM +0100, Christoph Hellwig wrote:
> I just compared this to a crude rebase of what I last sent out, and
> AFAICS the differences are:
>
> 1) basically all new io_uring handling due to the integrity stuff that
> went in
> 2) fixes for the NVMe FDP log page parsing
> 3) drop the support for the remapping of per-partition streams

Yep, pretty much. I will revisit the partition mapping. I just haven't
heard any use cases for divvying the streams up this way, so it's not
clear to me what the interface needs to provide.

> One thing that came I was pondering for a new version is if statx
> really is the right vehicle for this as it is a very common fast-path
> information. If we had a separate streaminfo ioctl or fcntl it might
> be easier to leave a bit spare space for extensibility. I can try to
> prototype that or we can leave it as-is because everyone is tired of
> the series.

Oh sure. I can live without the statx parts from this series if you
prefer we take additional time to consider other approaches. We have the
sysfs block attributes reporting the same information, and that is okay
for now.