Re: [PATCHv12 00/12] block write streams with nvme fdp

Christoph Hellwig
2024-12-09T12:55:15Z

I just compared this to a crude rebase of what I last sent out, and
AFAICS the differences are:

1) basically all new io_uring handling due to the integrity stuff that
went in
2) fixes for the NVMe FDP log page parsing
3) drop the support for the remapping of per-partition streams

conceptually this all looks fine to me. I'll throw in a few nitpicks
on the nvme bits, and I'd need to get up to speed a bit more on the
io_uring bits before commenting useful.

One thing that came I was pondering for a new version is if statx
really is the right vehicle for this as it is a very common fast-path
information. If we had a separate streaminfo ioctl or fcntl it might
be easier to leave a bit spare space for extensibility. I can try to
prototype that or we can leave it as-is because everyone is tired of
the series.