From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B8C940F8DF for ; Tue, 4 Aug 2026 08:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832795; cv=none; b=H4PcXPIMb8Hj0EE+jtcFYF2Ddk0TQ9Nfo+py7lPjDra6qqeSrhZx736lZxhhpTSpNS2aG+ziAOQIkU8D30Tirn6VE7JIEgOLpDtRiHzwkH6A3tAOXzaqKAhj7KthUaxCGOoSdkvEvupxSdK9q82czCQ5KNDHQR326W5JWilj1Cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832795; c=relaxed/simple; bh=St5xZjAvHbO5wVL5/bUSVAInpD9XhzCT+/yCzyLg26A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=THuJIq20wcgC+26OqxlSIN78uLpuWD77IsMHyV3gRAi/ccfnOUqjjyfJzuocS9H/w/fTitngNfaDyqeCEdAxjleAsHLb1Fe5lfUptyd5FdlegVrOUjH2DiA3YAf5VK5GsJo68AxW2bTmJ9rdMFMivdTNey08ME/fxeaMJSjC1L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8pdWUdr; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8pdWUdr" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so48519165ad.1 for ; Tue, 04 Aug 2026 01:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785832793; x=1786437593; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=64eSuQSg7peuhPy9EAyTkvD08lRNBOCEScrOfZTKXsQ=; b=a8pdWUdreBfl/WJduFzPJ7bPNmTNSJuEk9nRl42gbzij5MSOdvsqxQDhMitbA9g/kf GJfFeqUQ0+XkCCA2c26hmuugpcqwH8GliFJJKiOyjNF5sARUeA2Fjohuiq2H+7FuBmHe Iu4WSZYHeaOB+3P4yl93/tpaMX9P28j9A+D/jJfTGdSu1B4r+KK+0YqaM9Qi6w/ISZo4 CBmwCgAcsyRe4glJgIYJQNa6Ttmj1uUfxMjcbSAyAiYWeJd7mT+NPtVdcm0T+PZzQjBc S7qfH1ceFeNo6eXpLmtCbj8rlTvk0zLwQ+otuBOOrLRAirmGT+ASi3RWNOVuZEBiTU9o 2bwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785832793; x=1786437593; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=64eSuQSg7peuhPy9EAyTkvD08lRNBOCEScrOfZTKXsQ=; b=bzWnYl6ohizlnoP5LB7s+bDMPsU2qXQ3bznCcCs4XOjvMVkArKH7rxLSwKgt4RExDB 1BYDdMxcYL5WYkBPzENNNOVTpsT8WxYN6nA+CvQIgpehWZAha7xp9YAZm4zxX+IyKoWx wGSkdprrzWDEOysWoG/lsW0vNrFuXEPwvCfZE4UV8NckxYzGFJNCQn5Kt/nHx9LZNZkn o0+huBP3T0tM32j8jyBx0aSwhwbVW07SE8Gjh236GitwSXJBaDTFjBRlvF3ZjOXl3wA7 HFOEaSs7Fp0+zsHuu4NeIspPxjQLpvMsUMNqTG3KdWI9RU+gLYsGIzfIm+1RyVT8jW8y FnMw== X-Forwarded-Encrypted: i=1; AHgh+RoJLkvAUCT+SuRadPCgCN7dQoqk+ItyME+zK6MEyRROLRDXGnAK4EcZHOdqiAkKnkunXHfdwq+tKg==@vger.kernel.org X-Gm-Message-State: AOJu0Yyopxd5Gbu+5MJRsDGZiBV3etxzJeqfvqePezm4S/rhoOlUwmg/ O8vSnvrI6boFm0AmX17nrrtzhSe2s4cPUYH+JODkZs3Qxnpd7FUixYoD X-Gm-Gg: AR+sD13Jpkzd6RFCBAc8O6iIcDKp6cJZR0Aa8rjm63F+MDrqsATL9oW2e5kZ9fiUGMw xxkQK11WBYlLHmPhYRieltS6n20Vs8Xc+s4xplb8Sgu34Z2cbo5LWJjHXQdiCh/BXOslZ/2l6JP lZt3w1xGo35id0iezGnkhl/Tca6/j2FRiAExKTMIERZsyoNU4MS6nWxqWKf5vTSpJJH+1WO/VBf MWdC8RnhMar2JFLkX+6Fy87c0DJ5FhLlvPyIDvEV6SZGYQj7odvaLBNcziV0eP7DJqZhEvohcWp JsklX8V12NcHww1Ij+jMUC/WXfDeff0taUFu29V4ZJW+zZlRVhyUPUDWRA7sRp5kKJwuwGO1dqs /8GCseI0kxcKovSZWgUNqg8CnqRJMNbBtTIzvpmdYfnhwoQue6a1uJVtoYi+F7B/X4xghQyvntK wGGP10+3CoDxSA5EuhBfx6TgkZ2Mc0xQaEYVwOW2rGbrnEQNdjMr3zLRVy+WDf90OiLuIRoBNkD jQ7K0bJ4IAY77QKqf/5jii+KzR/0EdlUTC1z2FVK4U0Z9LiZOBvPfp83/O1UuLLpHG9Dv+uThSW mn+UBtws8FBz9yw9XCiu X-Received: by 2002:a17:902:da81:b0:2c9:e69f:8b0f with SMTP id d9443c01a7336-2d0521dd6e5mr137791555ad.17.1785832792742; Tue, 04 Aug 2026 01:39:52 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:541b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0a9f93703sm3064405ad.7.2026.08.04.01.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 01:39:51 -0700 (PDT) Message-ID: <214cf82d-742a-4753-bc86-c249366b54ed@gmail.com> Date: Tue, 4 Aug 2026 09:39:31 +0100 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/16] iov_iter: add iterator type for dmabuf maps To: Anuj gupta Cc: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe , Damien Le Moal , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , Vishal Verma , David Sterba , Ilya Dryomov , dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org References: Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/3/26 14:20, Anuj gupta wrote: > On Sat, Aug 1, 2026 at 9:19 PM Pavel Begunkov wrote: >> @@ -841,7 +857,7 @@ static unsigned long iov_iter_alignment_bvec(const struct iov_iter *i) >> >> unsigned long iov_iter_alignment(const struct iov_iter *i) >> { >> - if (likely(iter_is_ubuf(i))) { >> + if (likely(iter_is_ubuf(i)) || iov_iter_is_dmabuf_map(i)) { >> size_t size = i->count; >> if (size) >> return ((unsigned long)i->ubuf + i->iov_offset) | size; > > dmabuf_map shares the same union slot as ubuf, so this reads the map > pointer as a user address. gap_alignment() below already returns 0 > correctly for dmabuf - this should too. Checked the rest of this patch > (advance/revert/restore) - none of them dereference the union pointer > for dmabuf, so it's isolated to this one spot. Doesn't affect the > current series, nothing reaches this with a dmabuf iter yet. Ah yes, that's nonsense, it should've checked iov_offset instead. Thanks -- Pavel Begunkov