Re: [PATCH] io_uring: Fix getting file for timeout

[Jens Axboe <axboe@kernel.dk>]

On 11/13/19 3:05 PM, Pavel Begunkov wrote:
> On 14/11/2019 00:54, Jens Axboe wrote:
>> On Nov 13, 2019, at 2:48 PM, Pavel Begunkov <asml.silence@gmail.com> wrote:
>>>
>>> On 14/11/2019 00:37, Jens Axboe wrote:
>>>>> On 11/13/19 2:33 PM, Jens Axboe wrote:
>>>>> On 11/13/19 2:11 PM, Pavel Begunkov wrote:
>>>>>> For timeout requests and bunch of others io_uring tries to grab a file
>>>>>> with specified fd, which is usually stdin/fd=0.
>>>>>> Update io_op_needs_file()
>>>>>
>>>>> Good catch, thanks, applied.
>>>>
>>>> Care to send one asap for 5.4 as well? It'd just be TIMEOUT for that
>>>> one, but we need it fixed there, too.
>>>>
>>> Sure, I'll split this into 2 incremental patches then
>>
>> Just one patch is fine, it’ll be a conflict anyway. So no point in doing two patches for 5.5.
>>
> Ahh, didn't see the message.
> 
> I assumed you would drop the first one, and apply new 2 without a
> conflict. Either way, just skip whatever you don't need

That's fine, I'm keeping the one I have for 5.5 but making sure
the commit message reflects what it does, right now they both
just say 'timeout' which is only correct for the 5.4 variant.

I applied the 5.4 one, thanks.

-- 
Jens Axboe