From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 0/3] task/files cancellation fixes
Date: Sun, 20 Dec 2020 11:05:10 -0700 [thread overview]
Message-ID: <24fd5a4a-e5fa-0806-ec52-f8ffc0245a78@kernel.dk> (raw)
In-Reply-To: <b6795a97-9384-e105-7f64-7af821aed641@gmail.com>
On 12/20/20 11:01 AM, Pavel Begunkov wrote:
> On 20/12/2020 13:21, Pavel Begunkov wrote:
>> First two are only for task cancellation, the last one for both.
>>
>> Jens, do you remember the exact reason why you added the check
>> removed in [3/3]? I have a clue, but that stuff doesn't look
>> right regardless. See "exit: do exit_task_work() before shooting
>> off mm" thread.
>
> The question is answered, the bug is still here, but that's too
> early for 3/3. Please consider first 2 patches.
Yep, first two look good to me, thanks!
--
Jens Axboe
prev parent reply other threads:[~2020-12-20 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 13:21 [PATCH 0/3] task/files cancellation fixes Pavel Begunkov
2020-12-20 13:21 ` [PATCH 1/3] io_uring: always progress task_work on task cancel Pavel Begunkov
2020-12-20 13:21 ` [PATCH 2/3] io_uring: end waiting before task cancel attempts Pavel Begunkov
2020-12-20 13:21 ` [PATCH 3/3] io_uring: fix cancellation hangs Pavel Begunkov
2020-12-20 18:01 ` [PATCH 0/3] task/files cancellation fixes Pavel Begunkov
2020-12-20 18:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24fd5a4a-e5fa-0806-ec52-f8ffc0245a78@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox