Re: [RESEND PATCH v9 00/14] io-uring/xfs: support async buffered writes

Jens Axboe
2022-06-23T22:06:50Z

On 6/23/22 2:31 PM, Darrick J. Wong wrote:
>> Testing:
>> This patch has been tested with xfstests, fsx, fio and individual test programs.
>
> Good to hear. Will there be some new fstest coming/already merged?

It should not really require any new tests, as anything buffered +
io_uring on xfs will now use this code. But Stefan has run a bunch of
things on the side too, some of those synthetic (like ensure that
various parts of a buffered write range isn't cached, etc) and some more
generic (fsx). There might be some that could be turned into xfstests,
I'll let him answer that one.

> Hmm, well, vger and lore are still having stomach problems, so even the
> resend didn't result in #5 ending up in my mailbox. :(
>
> For the patches I haven't received, I'll just attach my replies as
> comments /after/ each patch subject line. What a way to review code!

Really not sure what's going on with email these days, it's quite a
pain... Thanks for taking a look so quickly!

I've added your reviewed-bys and also made that ternary change you
suggested. Only other change is addressing a kernelbot noticing that one
ret in the mm side was being set to zero only, so we could kill it. End
result:

https://git.kernel.dk/cgit/linux-block/log/?h=for-5.20/io_uring-buffered-writes

--
Jens Axboe