Re: [PATCH 01/10] block: set bip_vcnt correctly

Keith Busch
2024-05-01T08:03:47Z

On Wed, May 01, 2024 at 09:45:44AM +0200, Christoph Hellwig wrote:
> On Sat, Apr 27, 2024 at 08:16:52AM -0600, Keith Busch wrote:
> > > Please add a Fixes tag and submit it separately from the features.
> > >
> > > I'm actually kinda surprised the direct user mapping of integrity data
> > > survived so far without this.
> >
> > The only existing use case for user metadata is REQ_OP_DRV_IN/OUT, which
> > never splits, so these initial fixes only really matter after this
> > series adds new usage for generic READ/WRITE.
>
> Well, it matters to keep our contract up, even if we're not hitting it.
>
> And apparently another user just came out of the woods in dm land..

But the bug report from dm has nothing to do with user mapped metadata.
That bug existed before that was added, so yeah, patch 5 from this
series (or something like it) should be applied on its own.