From: Jens Axboe <axboe@kernel.dk>
To: io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: ensure that fsnotify is always called
Date: Sun, 20 Mar 2022 13:43:13 -0600 [thread overview]
Message-ID: <31ad4450-d1af-17ec-5e48-ea1eb6d95d0c@kernel.dk> (raw)
In-Reply-To: <44037852-263b-0110-c5c8-a64cdbcf547e@kernel.dk>
On 3/20/22 1:12 PM, Jens Axboe wrote:
> Ensure that we call fsnotify_modify() if we write a file, and that we
> do fsnotify_access() if we read it. This enables anyone using inotify
> on the file to get notified.
>
> Ditto for fallocate, ensure that fsnotify_modify() is called.
Forgot to put in the patch notes - this is not new for io_uring, aio
never called fsnotify either. But we do have a much broader scope that
aio which is all db and dio. Would be nice to have this be opt-in or
similar, though at least the per-op hit doesn't seem to be that large if
nobody is has a notifier registered (which is 99.99% of the use
cases...).
--
Jens Axboe
prev parent reply other threads:[~2022-03-20 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 19:12 [PATCH] io_uring: ensure that fsnotify is always called Jens Axboe
2022-03-20 19:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ad4450-d1af-17ec-5e48-ea1eb6d95d0c@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox