Re: [PATCH v3 4/4] io_uring: Add IORING_OP_DUP

[Jens Axboe <axboe@kernel.dk>]

On 3/21/26 5:21 PM, Daniele Di Proietto wrote:
> +	if (((id->flags & IORING_DUP_NEW_FIXED) == 0) ==
> +		    ((id->flags & IORING_DUP_OLD_FIXED) == 0) &&
> +	    id->old_fd == id->new_fd)
> +		return -EINVAL;

I think !(id->flags BLA) == would be shorter and hence easier to read.
This is hard to read, at least for me.

> +static int io_dup_to_fd(struct io_kiocb *req, unsigned int issue_flags,
> +			bool old_fixed, int old_fd, int new_fd, int o_flags)
> +{
> +	bool non_block = issue_flags & IO_URING_F_NONBLOCK;
> +	struct files_struct *files = current->files;
> +	struct file *old_file, *to_close = NULL;
> +	int err;
> +
> +	if (new_fd >= rlimit(RLIMIT_NOFILE))
> +		return -EBADF;
> +
> +	if (old_fixed)
> +		old_file = io_dup_get_old_file_fixed(req, issue_flags, old_fd);
> +
> +	{
> +		guard(spinlock)(&files->file_lock);

I did suggest a function, but if you're not doing that, at least use a
scoped_guard rather than have some randomly inserted scope here. That
looks like AI code..

-- 
Jens Axboe