RE: [PATCH 2/4] io_uring: add registered request arguments

[lizetao <lizetao1@huawei.com>]

Hi,

> -----Original Message-----
> From: Pavel Begunkov <asml.silence@gmail.com>
> Sent: Monday, December 30, 2024 9:30 PM
> To: io-uring@vger.kernel.org
> Cc: asml.silence@gmail.com; Anuj Gupta <anuj20.g@samsung.com>; Kanchan
> Joshi <joshi.k@samsung.com>
> Subject: [PATCH 2/4] io_uring: add registered request arguments
> 
> Similarly to registered wait arguments we want to have a pre-mapped space
> for various request arguments. Use the same parameter region, however as -
> >wait_args has different lifetime rules, add a new instance of struct
> io_reg_args.
> 
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
>  include/linux/io_uring_types.h | 2 ++
>  io_uring/register.c            | 3 +++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/include/linux/io_uring_types.h b/include/linux/io_uring_types.h
> index 49008f00d064..cd6642855533 100644
> --- a/include/linux/io_uring_types.h
> +++ b/include/linux/io_uring_types.h
> @@ -299,6 +299,8 @@ struct io_ring_ctx {
> 
>  		struct io_submit_state	submit_state;
> 
> +		struct io_reg_args	sqe_args;
> +
>  		/*
>  		 * Modifications are protected by ->uring_lock and -
> >mmap_lock.
>  		 * The flags, buf_pages and buf_nr_pages fields should be
> stable diff --git a/io_uring/register.c b/io_uring/register.c index
> b926eb053408..d2232b90a81d 100644
> --- a/io_uring/register.c
> +++ b/io_uring/register.c
> @@ -607,6 +607,9 @@ static int io_register_mem_region(struct io_ring_ctx
> *ctx, void __user *uarg)
>  		ctx->wait_args.ptr = io_region_get_ptr(&ctx->param_region);
>  		ctx->wait_args.size = rd.size;
>  	}
> +
> +	ctx->sqe_args.ptr = io_region_get_ptr(&ctx->param_region);
> +	ctx->sqe_args.size = rd.size;

Why not add an enum value against sqe_args? Will mixing it with
IORING_MEM_REGION_REG_WAIT_ARG cause management confusion?
>  	return 0;
>  }
> 
> --
> 2.47.1
> 

---
Li Zetao