From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>,
csander@purestorage.com, io-uring <io-uring@vger.kernel.org>
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv5 4/4] Add mixed sqe test for uring commands
Date: Tue, 21 Oct 2025 16:09:08 -0600 [thread overview]
Message-ID: <5bd2c43e-4b02-4cdb-90e1-ee5555600cb3@kernel.dk> (raw)
In-Reply-To: <20251021213329.784558-5-kbusch@meta.com>
> + ret = io_uring_wait_cqe(ring, &cqe);
> + if (ret < 0)
> + fprintf(stderr, "wait completion %d\n", ret);
> + else if (cqe->user_data != seq)
> + fprintf(stderr, "Unexpected user_data: %ld\n", (long) cqe->user_data);
> + else {
> + io_uring_cqe_seen(ring, cqe);
> + return T_EXIT_PASS;
> + }
> + return T_EXIT_FAIL;
All braces if one has braces. In a few different spots.
Outside of those little nits and the previous comment, I think this is
looking fine.
--
Jens Axboe
next prev parent reply other threads:[~2025-10-21 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251021213329.784558-1-kbusch@meta.com>
[not found] ` <20251021213329.784558-3-kbusch@meta.com>
2025-10-21 22:08 ` [PATCHv5 2/4] Add support IORING_SETUP_SQE_MIXED Jens Axboe
[not found] ` <20251021213329.784558-5-kbusch@meta.com>
2025-10-21 22:09 ` Jens Axboe [this message]
2025-10-13 18:00 [PATCHv5 0/4] liburing: support for mix sized sqe's Keith Busch
2025-10-13 18:00 ` [PATCHv5 4/4] Add mixed sqe test for uring commands Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bd2c43e-4b02-4cdb-90e1-ee5555600cb3@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).