From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: fix linked command file table usage
Date: Thu, 30 Jan 2020 02:19:28 +0300 [thread overview]
Message-ID: <60df3f6c-7174-a306-47bd-92ca82e2c432@gmail.com> (raw)
In-Reply-To: <828c41db-163e-c6db-5fdb-3f87246ac0ed@kernel.dk>
[-- Attachment #1.1: Type: text/plain, Size: 914 bytes --]
On 30/01/2020 01:44, Jens Axboe wrote:
> On 1/29/20 3:37 PM, Pavel Begunkov wrote:
>> FYI, for-next
>>
>> fs/io_uring.c: In function ‘io_epoll_ctl’:
>> fs/io_uring.c:2661:22: error: ‘IO_WQ_WORK_NEEDS_FILES’ undeclared (first use in
>> this function)
>> 2661 | req->work.flags |= IO_WQ_WORK_NEEDS_FILES;
>> | ^~~~~~~~~~~~~~~~~~~~~~
>> fs/io_uring.c:2661:22: note: each undeclared identifier is reported only once
>> for each function it appears in
>> make[1]: *** [scripts/Makefile.build:266: fs/io_uring.o] Error 1
>> make: *** [Makefile:1693: fs] Error 2
>
> Oops thanks, forgot that the epoll bits aren't in the 5.6 main branch
> yet, but they are in for-next. I'll fix it up there, thanks.
>
Great. Also, it seems revert of ("io_uring: only allow submit from owning task
") didn't get into for-next nor for-5.6/io_uring-vfs.
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-29 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:49 [PATCH] io_uring: fix linked command file table usage Jens Axboe
2020-01-29 22:37 ` Pavel Begunkov
2020-01-29 22:44 ` Jens Axboe
2020-01-29 23:19 ` Pavel Begunkov [this message]
2020-01-29 23:31 ` Jens Axboe
2020-01-29 23:38 ` Pavel Begunkov
2020-01-29 23:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60df3f6c-7174-a306-47bd-92ca82e2c432@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox