From: Pavel Begunkov <asml.silence@gmail.com>
To: Josef <josef.grieb@gmail.com>, Jens Axboe <axboe@kernel.dk>,
io-uring <io-uring@vger.kernel.org>
Cc: norman@apache.org
Subject: Re: [PATCH 5.11] io_uring: NULL files dereference by SQPOLL
Date: Sun, 8 Nov 2020 11:39:17 +0000 [thread overview]
Message-ID: <6313f2bb-d574-74d8-d757-cc5164112ee2@gmail.com> (raw)
In-Reply-To: <CAAss7+oBjNfFXV8O5DaLB0ih6EvcmSE=4V9bB5g2RY0R1oXftw@mail.gmail.com>
On 08/11/2020 06:50, Josef wrote:
>> Josef, could you try this one?
>
> the null files dereference error no longer occurs, but after a certain
> point in time the OP_READ operation always returns -EFAULT
That confirms the issue, and for efaults, as describes, I expect them to
start falling out after the task-creator exits or do exec. Just to note
that the patch only propagates errors and doesn't change the semantics.
>
> BTW forgot to mention that the NULL files dereference error only
> occurs when OP_READ returns a -EFAULT
--
Pavel Begunkov
next prev parent reply other threads:[~2020-11-08 11:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 21:16 [PATCH 5.11] io_uring: NULL files dereference by SQPOLL Pavel Begunkov
2020-11-07 21:18 ` Pavel Begunkov
2020-11-07 21:54 ` Pavel Begunkov
2020-11-07 22:28 ` Jens Axboe
2020-11-07 22:47 ` Pavel Begunkov
2020-11-07 23:18 ` Jens Axboe
2020-11-08 2:09 ` Josef
2020-11-08 6:50 ` Josef
2020-11-08 11:39 ` Pavel Begunkov [this message]
2020-11-08 11:31 ` Pavel Begunkov
2020-11-08 11:24 ` Pavel Begunkov
2020-11-07 22:30 ` Jens Axboe
2020-11-07 22:49 ` Pavel Begunkov
2020-11-07 23:17 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-11-08 12:55 Pavel Begunkov
2020-11-09 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6313f2bb-d574-74d8-d757-cc5164112ee2@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=josef.grieb@gmail.com \
--cc=norman@apache.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox