From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>, Dylan Yudaken <dylany@meta.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Gilang Fachrezy <gilang4321@gmail.com>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Muhammad Rizki <kiizuha@gnuweeb.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
VNLX Kernel Department <kernel@vnlx.org>
Subject: Re: [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function
Date: Thu, 24 Nov 2022 06:27:29 -0700 [thread overview]
Message-ID: <6491d7b5-0a52-e6d1-0f86-d36ec88bbc15@kernel.dk> (raw)
In-Reply-To: <b303bde6-91b1-2ea2-7b1d-e64546c8ae7f@gnuweeb.org>
On 11/24/22 4:47 AM, Ammar Faizi wrote:
> On 11/24/22 5:14 PM, Dylan Yudaken wrote:
>> I think changing the tests to use the public API is probably better
>> than exporting this function. I don't believe it has much general use?
>
> But there is no public API that does the same thing. I'll mark it
> as static and create a copy of that function in iopoll.c (in v2).
>
> Something like this, what do you think?
Yeah I think this is better for now, and then we can work on fixing
the test. Sanity of the core parts of the library is a lot more
important than some test case.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-24 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 8:00 [PATCH liburing v1 0/7] Ensure we mark internal functions and variables as static Ammar Faizi
2022-11-24 8:00 ` [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function Ammar Faizi
2022-11-24 10:14 ` Dylan Yudaken
2022-11-24 11:47 ` Ammar Faizi
2022-11-24 13:27 ` Jens Axboe [this message]
2022-11-24 8:00 ` [PATCH liburing v1 2/7] test/io_uring_setup: Remove unused functions Ammar Faizi
2022-11-24 8:00 ` [PATCH liburing v1 3/7] ucontext-cp: Remove an unused function Ammar Faizi
2022-11-24 8:00 ` [PATCH liburing v1 4/7] tests: Mark internal functions as static Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 5/7] ucontext-cp: " Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 6/7] test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 7/7] github: Add `-Wmissing-prototypes` for GitHub CI bot Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6491d7b5-0a52-e6d1-0f86-d36ec88bbc15@kernel.dk \
--to=axboe@kernel.dk \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=dylany@meta.com \
--cc=gilang4321@gmail.com \
--cc=gwml@vger.gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=kernel@vnlx.org \
--cc=kiizuha@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox