From: Jens Axboe <axboe@kernel.dk>
To: David Wei <dw@davidwei.uk>, io-uring@vger.kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH v1 2/3] io_uring: do not set no_iowait if IORING_ENTER_NO_WAIT
Date: Fri, 16 Aug 2024 12:49:33 -0600 [thread overview]
Message-ID: <687efed7-a25e-4962-9e63-f24f9c3e72fe@kernel.dk> (raw)
In-Reply-To: <20240816180145.14561-3-dw@davidwei.uk>
On 8/16/24 12:01 PM, David Wei wrote:
> @@ -2414,6 +2414,8 @@ static int io_cqring_wait(struct io_ring_ctx *ctx, int min_events, u32 flags,
> iowq.nr_timeouts = atomic_read(&ctx->cq_timeouts);
> iowq.cq_tail = READ_ONCE(ctx->rings->cq.head) + min_events;
> iowq.timeout = KTIME_MAX;
> + if (flags & IORING_ENTER_NO_IOWAIT)
> + iowq.no_iowait = true;
Oh, and this should be:
iowq.no_iowait = flags & IORING_ENTER_NO_IOWAIT;
to avoid leaving this field uninitialized by default if the flag isn't
set. The struct isn't initialized to zero.
--
Jens Axboe
next prev parent reply other threads:[~2024-08-16 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 18:01 [PATCH v1 0/3] io_uring: add option to not set in_iowait David Wei
2024-08-16 18:01 ` [PATCH v1 1/3] io_uring: add IORING_ENTER_NO_IOWAIT flag David Wei
2024-08-16 18:35 ` Jens Axboe
2024-08-16 18:01 ` [PATCH v1 2/3] io_uring: do not set no_iowait if IORING_ENTER_NO_WAIT David Wei
2024-08-16 18:38 ` Jens Axboe
2024-08-16 22:23 ` David Wei
2024-08-16 18:49 ` Jens Axboe [this message]
2024-08-16 18:01 ` [PATCH v1 3/3] io_uring: add IORING_FEAT_IOWAIT_TOGGLE feature flag David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687efed7-a25e-4962-9e63-f24f9c3e72fe@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox