public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org
Subject: Re: [PATCH 08/11] io_uring/poll: add IO_POLL_FINISH_FLAG
Date: Fri, 7 Feb 2025 07:29:56 -0700	[thread overview]
Message-ID: <6b27f9ee-290f-4905-a929-82d68f80ab2a@kernel.dk> (raw)
In-Reply-To: <42382d54-4789-42dc-af17-79071af48849@gmail.com>

On 2/7/25 5:15 AM, Pavel Begunkov wrote:
> On 2/4/25 19:46, Jens Axboe wrote:
>> Use the same value as the retry, doesn't need to be unique, just
>> available if the poll owning mechanism user wishes to use it for
>> something other than a retry condition.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> ---
>>   io_uring/poll.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/io_uring/poll.h b/io_uring/poll.h
>> index 2f416cd3be13..97d14b2b2751 100644
>> --- a/io_uring/poll.h
>> +++ b/io_uring/poll.h
>> @@ -23,6 +23,7 @@ struct async_poll {
>>     #define IO_POLL_CANCEL_FLAG    BIT(31)
>>   #define IO_POLL_RETRY_FLAG    BIT(30)
>> +#define IO_POLL_FINISH_FLAG    IO_POLL_RETRY_FLAG
> 
> The patches use io_poll_get_ownership(), which already might set
> the flag and with a different meaning put into it.

Oh true, I totally missed that. I'll just add another flag for it
instead and shrink the ref mask.

-- 
Jens Axboe


  reply	other threads:[~2025-02-07 14:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 19:46 [PATCHSET v2 0/11] io_uring epoll wait support Jens Axboe
2025-02-04 19:46 ` [PATCH 01/11] eventpoll: abstract out main epoll reaper into a function Jens Axboe
2025-02-04 19:46 ` [PATCH 02/11] eventpoll: add helper to remove wait entry from wait queue head Jens Axboe
2025-02-04 19:46 ` [PATCH 03/11] eventpoll: abstract out ep_try_send_events() helper Jens Axboe
2025-02-04 19:46 ` [PATCH 04/11] eventpoll: add struct wait_queue_entry argument to epoll_wait() Jens Axboe
2025-02-04 19:46 ` [PATCH 05/11] eventpoll: add ep_poll_queue() loop Jens Axboe
2025-02-07 12:28   ` Pavel Begunkov
2025-02-07 14:29     ` Jens Axboe
2025-02-04 19:46 ` [PATCH 06/11] io_uring/epoll: remove CONFIG_EPOLL guards Jens Axboe
2025-02-04 19:46 ` [PATCH 07/11] io_uring/poll: pull ownership handling into poll.h Jens Axboe
2025-02-04 19:46 ` [PATCH 08/11] io_uring/poll: add IO_POLL_FINISH_FLAG Jens Axboe
2025-02-07 12:15   ` Pavel Begunkov
2025-02-07 14:29     ` Jens Axboe [this message]
2025-02-04 19:46 ` [PATCH 09/11] io_uring/epoll: add support for IORING_OP_EPOLL_WAIT Jens Axboe
2025-02-07 12:38   ` Pavel Begunkov
2025-02-07 17:13     ` Jens Axboe
2025-02-04 19:46 ` [PATCH 10/11] io_uring/epoll: add support for provided buffers Jens Axboe
2025-02-04 19:46 ` [PATCH 11/11] io_uring/epoll: add multishot support for IORING_OP_EPOLL_WAIT Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b27f9ee-290f-4905-a929-82d68f80ab2a@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=brauner@kernel.org \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox