From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B042290DBB for ; Tue, 5 May 2026 07:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777966748; cv=none; b=pvVtLwI7fhOlMg9JE3yGgSXs5cN4Tm/Y4wMWfstVfTuZnkFybyXvwCesE/duKDf5SHE4YdjlOloeQhQpBhPYJXz0XK86XYoIPrzuXM0SUYbdPiv44Bw4WcxvbkmL0JRa/GlNjmk+v7D+cHPrj9ebrYcGWREphfORmV3vCpwpFnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777966748; c=relaxed/simple; bh=x3t7CqHGPD4J4L/ylzzph1OeM21h/k34NS8Qy+vR88o=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=ibw5SZoe0OvPKnuOvoa/Zss59khXEWItFeA9cqRZTyXvT56BA9WiMl7O1h7j/8FdmCPSAhHrSfFYZqrBCi8kQxR8WsQmv2DwzSuIWaYtHDSElZuQ5IsTrLfrCqDCOczgzG9ovoJLszd1tHpoP69olyEJSwN7gYN+5HTqllImuug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=Uy4soQ0F; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="Uy4soQ0F" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48d146705b4so7213365e9.3 for ; Tue, 05 May 2026 00:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1777966744; x=1778571544; darn=vger.kernel.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=EIGGuN+GhElqlA1tsuYCYgDDvgyDZWXKwIZIzXJ97Fs=; b=Uy4soQ0FeusWmgvFZGL9+t0lZv2y1PwHBE5IHSs4uXEuhjJOAbq4/ZVbKRESp+OBjZ WOlUhUSxmUNrM9xYAQfhLCNuLJ/UcgrtOhK1dX2DdjVXpaYaLR9YxWVTfvideDdQtIRn xiIVBydymbjEWXXgA5GoqQzgNAr8pRdcNhSEhbxwkpFDEs5NWlxxTLM7qiGnHuYxg50G B9pttpfojRoHGPC16o+rFcOazmFupqcdSbEV/p5M3Nyl/DFg53hflU5K9q+WrZQeehOB 6BC9fRkLStrQzSMpxCmlQ2HkGSs6CT0fP3qI1jystljaF8YD5xU1HRZM8tYz/bIKbRtw 8Xnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777966744; x=1778571544; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EIGGuN+GhElqlA1tsuYCYgDDvgyDZWXKwIZIzXJ97Fs=; b=fl6QD0RO/5EOGpAk2Wnkwb/yFB+CCRhJ9OE9BvznBkUX3m0OopByMv5hR/9he9UPVQ VI2b7Ks0rvzdhO2Jwu3KPgooRKS5FhUCBfc2NJig154YpSgg6gdDt7qvEfLb19J8cCl8 tWCvsXTinEkpnvheaLWG7DRwDhunZaT+zalipZelLIxdtkIjSz8dcteBcxJVrFmcla2H phJjSwzhsudVBdTYvBsphQwS/QpBS2FlXgz8nCXPKw7Nr5EZDc1TQoFtmcV2QfntnNdl qbCib8FmSnfhGa40FIwxxQEk5VcFsb0QR2pYLNzQnl00QFKFNTQcLZU5HG5KJz7foTNJ vHKA== X-Gm-Message-State: AOJu0YzECQk+gruH8iEg6LqWVfWEIOYFt8TpYM8d5n0sCBl7bZlsP7CD aT6tfKOIMqK7bsePgHJZs8d22nrRF48pxM+qoy8G2qYE9JHw6mAOvRiT69Y1ErM2eBXU/h84KuO CWMZpdV8= X-Gm-Gg: AeBDieubzHc3SJ9ZkyoOj27iLbx5yhJu+BfvJzE+6paO+ACmtFcZzIn/IgEvXYjs8EL hVC8bry7wbHRVO0lZWusyiw8rn1vfhm/qQcTpOoUzpR/yOoqBP7OCEcf0E2kzlAE4Dec4qpXF9v j2xCfPWkp0NUIQU1DxUaqt8QUlEn9px9aGqjCExWKgeoAsKggp3sO8MOkkIfjbzUh/2EVFf7kmN lsvN3eaT38HjL+seZJ5clmZ0VZBQetIEUCBhQUhe1dmtXWAQ9cED3h6wFfP24Clf7ZYkT9Ys+NX 5Nw83vWyAGbOvkE9zZSxJR0i7H5kmWTRT8oBnfFO4DG85J3OsCMBuINzQXUmqi23DKn/d7DnWiq owg/CtvyGW/tIoeypqVMPM2iNZC+rg8g8FEmAml2wlcsWv7umO5Q8F3vmxA274V4tXiZQQH8SCj 0xClZPjzf9boWKviw471I7OX8ArVg9HZAqKSJWO7cnBuFfuScb2GiYBYXcWXCC4Jvmi1TqdlGJ6 Drc9uwC9gttkw4BPnlm X-Received: by 2002:a05:600c:810a:b0:48a:592c:e655 with SMTP id 5b1f17b1804b1-48d18be5ab5mr27767125e9.17.1777966743648; Tue, 05 May 2026 00:39:03 -0700 (PDT) Received: from [10.211.9.173] ([213.147.98.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a82301b7bsm452022915e9.11.2026.05.05.00.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 00:39:02 -0700 (PDT) Message-ID: <6de5d329-9162-4992-85cb-f946f2d5c0b1@kernel.dk> Date: Tue, 5 May 2026 01:39:01 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: io-uring Cc: Andres Freund From: Jens Axboe Subject: [PATCH] io_uring/rsrc: remove registered buffer 1GB limit Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit There's no real reason to have a limit, as the memory is accounted by the lockmem limits anyway, if any exist. io_pin_pages() will still restrict the maximum allowed limit per buffer, which is INT_MAX number of pages. For a 4kb page size system, the limit is 8TB. Reported-by: Andres Freund Signed-off-by: Jens Axboe --- diff --git a/io_uring/memmap.c b/io_uring/memmap.c index 4f9b439319c4..74149b1cae5c 100644 --- a/io_uring/memmap.c +++ b/io_uring/memmap.c @@ -53,7 +53,7 @@ struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages) nr_pages = end - start; if (WARN_ON_ONCE(!nr_pages)) return ERR_PTR(-EINVAL); - if (WARN_ON_ONCE(nr_pages > INT_MAX)) + if (nr_pages > INT_MAX) return ERR_PTR(-EOVERFLOW); pages = kvmalloc_objs(struct page *, nr_pages, GFP_KERNEL_ACCOUNT); diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 650303626be6..0b85b35bfe08 100644 --- a/io_uring/rsrc.c +++ b/io_uring/rsrc.c @@ -88,8 +88,14 @@ int io_validate_user_buf_range(u64 uaddr, u64 ulen) unsigned long tmp, base = (unsigned long)uaddr; unsigned long acct_len = (unsigned long)PAGE_ALIGN(ulen); - /* arbitrary limit, but we need something */ - if (ulen > SZ_1G || !ulen) + /* + * No specific buffer length limit outside of what io_pin_pages() + * limits us to. + */ + if (!ulen) + return -EFAULT; + /* 32-bit sanity checking */ + if (ulen > ULONG_MAX || uaddr > ULONG_MAX) return -EFAULT; if (check_add_overflow(base, acct_len, &tmp)) return -EOVERFLOW; -- Jens Axboe