public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: John David Anglin <dave.anglin@bell.net>,
	linux-parisc <linux-parisc@vger.kernel.org>
Cc: io-uring@vger.kernel.org, Helge Deller <deller@gmx.de>
Subject: Re: liburing test results on hppa
Date: Thu, 16 Feb 2023 16:32:20 -0700	[thread overview]
Message-ID: <6eddaf2b-991f-f848-4832-7005eccdeffa@kernel.dk> (raw)
In-Reply-To: <b0ad2098-979e-f256-a553-401bad9921e0@bell.net>

On 2/16/23 4:26?PM, John David Anglin wrote:
> On 2023-02-16 6:12 p.m., Jens Axboe wrote:
>> On 2/16/23 4:00?PM, John David Anglin wrote:
>>> Running test buf-ring.t bad run 0/0 = -233
>>> test_running(1) failed
>>> Test buf-ring.t failed with ret 1
>> As mentioned previously, this one and the other -233 I suspect are due
>> to the same coloring issue as was fixed by Helge's patch for the ring
>> mmaps, as the provided buffer rings work kinda the same way. The
>> application allocates some aligned memory, and registers it and the
>> kernel then maps it.
>>
>> I wonder if these would work properly if the address was aligned to
>> 0x400000? Should be easy to verify, just modify the alignment for the
>> posix_memalign() calls in test/buf-ring.c.
> Doesn't help.  Same error.  Can you point to where the kernel maps it?

Yep, it goes io_uring.c:io_uring_register() ->
kbuf.c:io_register_pbuf_ring() -> rsrc.c:io_pin_pages() which ultimately
calls pin_user_pages() to map the memory.

-- 
Jens Axboe


  reply	other threads:[~2023-02-16 23:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 23:00 liburing test results on hppa John David Anglin
2023-02-16 23:12 ` Jens Axboe
2023-02-16 23:26   ` John David Anglin
2023-02-16 23:32     ` Jens Axboe [this message]
2023-02-17  2:33       ` Jens Axboe
2023-02-17  2:59         ` John David Anglin
2023-02-21 19:55           ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eddaf2b-991f-f848-4832-7005eccdeffa@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox