From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-block@vger.kernel.org
Cc: zeba.hrvoje@gmail.com, liuyun01@kylinos.cn
Subject: Re: [PATCHSET 0/2] io_uring support for linked timeouts
Date: Fri, 15 Nov 2019 14:26:33 -0700 [thread overview]
Message-ID: <71860cea-313d-b6ef-895d-9635c73d7530@kernel.dk> (raw)
In-Reply-To: <06929659-a545-87c8-fbf4-edfc01c69520@gmail.com>
On 11/15/19 2:22 PM, Pavel Begunkov wrote:
> On 15/11/2019 22:34, Jens Axboe wrote:
>> How about something like this? Should work (and be valid) to have any
>> sequence of timeout links, as long as there's something in front of it.
>> Commit message has more details.
>
> If you don't mind, I'll give a try rewriting this. A bit tight
> on time, so hopefully by this Sunday.
>
> In any case, there are enough of edge cases, I need to spend some
> time to review and check it.
Of course, appreciate more eyes on this for sure. We'll see what happens
with 5.4 release, I suspect it won't happen until 11/24. In any case,
this is not really staged yet, just sitting in for-5.5/io_uring-post
as part of a series that'll likely go in after the initial merge.
> REQ1 -> LINKED_TIMEOUT -> REQ2 -> REQ3
> Is this a valid case? Just to check that I got this "can't have both" right.
> If no, why so? I think there are a lot of use cases for this.
Yes, it's valid. With the recently posted stuff, the only invalid case
is having a linked timeout as the first entry since that's nonsensical.
It has to be linked from a previous request. We no longer need to
restrict where the linked timeout appears otherwise.
--
Jens Axboe
next prev parent reply other threads:[~2019-11-15 21:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 21:11 [PATCHSET 0/2] io_uring support for linked timeouts Jens Axboe
2019-11-05 21:11 ` [PATCH 1/2] io_uring: abstract out io_async_cancel_one() helper Jens Axboe
2019-11-05 21:11 ` [PATCH 2/2] io_uring: add support for linked SQE timeouts Jens Axboe
2019-11-14 21:24 ` [PATCHSET 0/2] io_uring support for linked timeouts Pavel Begunkov
2019-11-14 22:37 ` Jens Axboe
2019-11-15 9:40 ` Pavel Begunkov
2019-11-15 14:21 ` Pavel Begunkov
2019-11-15 15:13 ` Jens Axboe
2019-11-15 17:11 ` Pavel Begunkov
2019-11-15 19:34 ` Jens Axboe
2019-11-15 21:16 ` Jens Axboe
2019-11-15 21:38 ` Pavel Begunkov
2019-11-15 22:15 ` Jens Axboe
2019-11-15 22:19 ` Pavel Begunkov
2019-11-15 22:23 ` Pavel Begunkov
2019-11-15 22:25 ` Jens Axboe
2019-11-15 21:22 ` Pavel Begunkov
2019-11-15 21:26 ` Jens Axboe [this message]
2019-11-19 21:11 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71860cea-313d-b6ef-895d-9635c73d7530@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=zeba.hrvoje@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox