Re: [GIT PULL] io_uring fixes for 6.0-rc1

[Jens Axboe <axboe@kernel.dk>]

On 8/12/22 4:25 PM, Jens Axboe wrote:
> On 8/12/22 4:23 PM, Keith Busch wrote:
>> On Fri, Aug 12, 2022 at 04:19:06PM -0600, Jens Axboe wrote:
>>> On 8/12/22 4:11 PM, Jens Axboe wrote:
>>>> For that one suggestion, I suspect this will fix your issue. It's
>>>> obviously not a thing of beauty...
>>>
>>> While it did fix compile, it's also wrong obviously as io_rw needs to be
>>> in that union... Thanks Keith, again!
>>
>> I'd prefer if we can get away with forcing struct kiocb to not grow.
>> The below should have the randomization move the smallest two fields
>> together so we don't introduce more padding than necessary:
> 
> Keith suggested the same thing and was going to send it out, and I
> definitely like that a lot more than mine. Can you commit something like
> this? Should probably add a comment on why these are grouped like that,
> though.

Guess I'm a bit too quick here as I read this one as being from Linus.
Linus, what do you think of this? It'll prevent kiocb from growing due
to fields being moved around.

-- 
Jens Axboe