From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Cc: asml.silence@gmail.com, krisman@suse.de
Subject: Re: [PATCH 3/3] io_uring/rw: add support for IORING_OP_READ_MULTISHOT
Date: Tue, 12 Sep 2023 12:21:58 -0600 [thread overview]
Message-ID: <7c169870-190c-4b63-9a5b-30d6c41f7e99@kernel.dk> (raw)
In-Reply-To: <20230912172458.1646720-4-axboe@kernel.dk>
On 9/12/23 11:24 AM, Jens Axboe wrote:
> @@ -863,10 +879,61 @@ int io_read(struct io_kiocb *req, unsigned int issue_flags)
> int ret;
>
> ret = __io_read(req, issue_flags);
> - if (unlikely(ret < 0))
> - return ret;
> + if (ret >= 0)
> + return kiocb_done(req, ret, issue_flags);
> +
> + return ret;
> +}
Looks like this one got folded into the wrong patch, this belongs with
patch 1 of course. The current git tree is correct, patch 1 does it this
way and patch 3 doesn't touch it.
--
Jens Axboe
next prev parent reply other threads:[~2023-09-12 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 17:24 [PATCHSET v2 0/3] Add support for multishot reads Jens Axboe
2023-09-12 17:24 ` [PATCH 1/3] io_uring/rw: split io_read() into a helper Jens Axboe
2023-09-12 17:24 ` [PATCH 2/3] io_uring/rw: mark readv/writev as vectored in the opcode definition Jens Axboe
2023-09-12 17:24 ` [PATCH 3/3] io_uring/rw: add support for IORING_OP_READ_MULTISHOT Jens Axboe
2023-09-12 18:21 ` Jens Axboe [this message]
2023-09-12 18:39 ` [PATCHSET v2 0/3] Add support for multishot reads Gabriel Krisman Bertazi
2023-09-12 19:11 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2023-09-11 20:40 [PATCHSET " Jens Axboe
2023-09-11 20:40 ` [PATCH 3/3] io_uring/rw: add support for IORING_OP_READ_MULTISHOT Jens Axboe
2023-09-11 23:57 ` Gabriel Krisman Bertazi
2023-09-12 0:46 ` Jens Axboe
2023-09-12 0:53 ` Jens Axboe
2023-09-12 0:38 ` Gabriel Krisman Bertazi
2023-09-12 0:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c169870-190c-4b63-9a5b-30d6c41f7e99@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=krisman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox