From: Pavel Begunkov <asml.silence@gmail.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: pass struct io_tw_state by value
Date: Wed, 12 Feb 2025 13:31:29 +0000 [thread overview]
Message-ID: <80ba6f5e-33dc-4f06-9277-96ae99d89239@gmail.com> (raw)
In-Reply-To: <20250211214539.3378714-1-csander@purestorage.com>
On 2/11/25 21:45, Caleb Sander Mateos wrote:
...
> --- a/io_uring/waitid.c
> +++ b/io_uring/waitid.c
> @@ -14,11 +14,11 @@
> #include "io_uring.h"
> #include "cancel.h"
> #include "waitid.h"
> #include "../kernel/exit.h"
>
> -static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state *ts);
> +static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state ts);
>
> #define IO_WAITID_CANCEL_FLAG BIT(31)
> #define IO_WAITID_REF_MASK GENMASK(30, 0)
>
> struct io_waitid {
> @@ -129,11 +129,11 @@ static void io_waitid_complete(struct io_kiocb *req, int ret)
>
> ret = io_waitid_finish(req, ret);
> if (ret < 0)
> req_set_fail(req);
> io_req_set_res(req, ret, 0);
> - io_req_task_complete(req, &ts);
This thing will need to be fixed first
> + io_req_task_complete(req, ts);
> }
--
Pavel Begunkov
next prev parent reply other threads:[~2025-02-12 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:45 [PATCH] io_uring: pass struct io_tw_state by value Caleb Sander Mateos
2025-02-12 13:31 ` Pavel Begunkov [this message]
2025-02-12 14:33 ` Jens Axboe
2025-02-12 14:49 ` Pavel Begunkov
2025-02-12 14:50 ` Jens Axboe
2025-02-13 16:54 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ba6f5e-33dc-4f06-9277-96ae99d89239@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox