From: lizetao <lizetao1@huawei.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
"asml.silence@gmail.com" <asml.silence@gmail.com>,
lizetao <lizetao1@huawei.com>
Subject: 答复: [PATCH -next] io_uring: add support for fchmod
Date: Sat, 23 Nov 2024 12:23:39 +0000 [thread overview]
Message-ID: <8609cb5ca3bf4d2c8018ec2339f36430@huawei.com> (raw)
In-Reply-To: <2fe3005b-279d-489d-823f-731c6a52e5b1@kernel.dk>
Hi
>>On 11/19/24 1:12 AM, lizetao wrote:
>> Adds support for doing chmod through io_uring. IORING_OP_FCHMOD
>>behaves like fchmod(2) and takes the same arguments.
> Looks pretty straight forward. The only downside is the forced use of REQ_F_FORCE_ASYNC - did you look into how feasible it would be to allow non-blocking issue of this? Would imagine the majority of fchmod calls end up not blocking in the first place.
Yes, I considered fchmod to allow asynchronous execution and wrote a test case to test it, the results are as follows:
fchmod:
real 0m1.413s
user 0m0.253s
sys 0m1.079s
io_uring + fchmod:
real 0m1.268s
user 0m0.015s
sys 0m5.739s
There is about a 10% improvement.
> --
>Jens Axboe
--
Li Zetao
next prev parent reply other threads:[~2024-11-23 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 8:12 [PATCH -next] io_uring: add support for fchmod lizetao
2024-11-20 15:14 ` Jens Axboe
2024-11-23 12:23 ` lizetao [this message]
2024-11-24 16:18 ` 答复: " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8609cb5ca3bf4d2c8018ec2339f36430@huawei.com \
--to=lizetao1@huawei.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox