Linux io-uring development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, Woraphat Khiaodaeng <worapat.kd2@gmail.com>
Cc: Jens Axboe <axboe@kernel.dev>
Subject: Re: [PATCH] io_uring: restore RCU read section in io_req_local_work_add()
Date: Thu, 9 Jul 2026 11:46:00 -0600	[thread overview]
Message-ID: <87cedd37-0f88-40c0-90d9-65b78d4f69a6@kernel.dk> (raw)
In-Reply-To: <178361907941.14321.2989447050307137432.b4-ty@b4>

On 7/9/26 11:44 AM, Jens Axboe wrote:
> 
> On Thu, 09 Jul 2026 10:51:00 +0700, Woraphat Khiaodaeng wrote:
>> The task-work refactor that moved io_req_local_work_add() out of
>> io_uring.c into the new io_uring/tw.c dropped the whole-body guard(rcu)()
>> that used to cover the function body.
>>
>> For DEFER_TASKRUN rings the ring teardown still relies on that RCU read
>> section pairing with its grace period:
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] io_uring: restore RCU read section in io_req_local_work_add()
>       commit: 648790e0952789527ec68548edbedbc0fcff43b5

Side note: with your patch applied, we can also do:

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git/commit/?h=io_uring-7.2&id=f3176c8ac4217c88fe1147ab084c47092921ffc4

as io_ctx_mark_taskrun() is no longer called outside the RCU read side
lock anymore. So I did that on top.

-- 
Jens Axboe


      reply	other threads:[~2026-07-09 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  3:51 [PATCH] io_uring: restore RCU read section in io_req_local_work_add() Woraphat Khiaodaeng
2026-07-09 17:44 ` Jens Axboe
2026-07-09 17:46   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cedd37-0f88-40c0-90d9-65b78d4f69a6@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=axboe@kernel.dev \
    --cc=io-uring@vger.kernel.org \
    --cc=worapat.kd2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox