From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 5.10] io_uring: fix overflowed cancel w/ linked ->files
Date: Wed, 4 Nov 2020 08:52:24 -0700 [thread overview]
Message-ID: <8e23fda5-072f-2943-9937-2626e304013f@kernel.dk> (raw)
In-Reply-To: <f0fb77b2-fd84-0a62-3499-567d575f31ff@gmail.com>
On 11/4/20 8:41 AM, Pavel Begunkov wrote:
> On 04/11/2020 15:25, Jens Axboe wrote:
>> On 11/4/20 6:39 AM, Pavel Begunkov wrote:
>>> Current io_match_files() check in io_cqring_overflow_flush() is useless
>>> because requests drop ->files before going to the overflow list, however
>>> linked to it request do not, and we don't check them.
>>>
>>> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
>>> ---
>>>
>>> Jens, there will be conflicts with 5.11 patches, I'd appreciate if you
>>> could ping me when/if you merge it into 5.11
>>
>> Just for this one:
>>
>> io_uring: link requests with singly linked list
>>
>> How does the below look, now based on top of this patch added to
>> io_uring-5.10:
>
> Yep, it looks exactly like in my 5.11!
OK great, thanks for checking. Pushing it out.
--
Jens Axboe
prev parent reply other threads:[~2020-11-04 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 13:39 [PATCH 5.10] io_uring: fix overflowed cancel w/ linked ->files Pavel Begunkov
2020-11-04 15:25 ` Jens Axboe
2020-11-04 15:41 ` Pavel Begunkov
2020-11-04 15:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e23fda5-072f-2943-9937-2626e304013f@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox