Re: [PATCH] io_uring: uring_cmd: add multishot support without poll

[Jens Axboe <axboe@kernel.dk>]

On 8/19/25 5:19 AM, Ming Lei wrote:
>>> @@ -251,6 +264,11 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
>>>  	}
>>>  
>>>  	ret = file->f_op->uring_cmd(ioucmd, issue_flags);
>>> +	if (ioucmd->flags & IORING_URING_CMD_MULTISHOT) {
>>> +		if (ret >= 0)
>>> +			return IOU_ISSUE_SKIP_COMPLETE;
>>> +		io_kbuf_recycle(req, issue_flags);
>>> +	}
>>>  	if (ret == -EAGAIN) {
>>>  		ioucmd->flags |= IORING_URING_CMD_REISSUE;
>>>  		return ret;
>>
>> Missing recycle for -EAGAIN?
> 
> io_kbuf_recycle() is done above if `ret < 0`

Inside the multishot case. I don't see anywhere where it's forbidden to
use IOSQE_BUFFER_SELECT without having multishot set? Either that needs
to be explicit for now, or the recycling should happen generically.
Probably the former I would suspect.

-- 
Jens Axboe