From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/waitid: remove #ifdef CONFIG_COMPAT
Date: Mon, 24 Feb 2025 19:10:20 +0000 [thread overview]
Message-ID: <91c200cd-2b2d-4756-b641-aa1bd4ec9796@gmail.com> (raw)
In-Reply-To: <fedd8628-327a-473b-9443-4504fab48c2c@kernel.dk>
On 2/24/25 17:55, Jens Axboe wrote:
> On 2/24/25 10:53 AM, Caleb Sander Mateos wrote:
>> On Mon, Feb 24, 2025 at 9:44 AM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 2/24/25 10:23 AM, Caleb Sander Mateos wrote:
>>>> io_is_compat() is already defined to return false if CONFIG_COMPAT is
>>>> disabled. So remove the additional #ifdef CONFIG_COMPAT guards. Let the
>>>> compiler optimize out the dead code when CONFIG_COMPAT is disabled.
>>>
>>> Would you mind if I fold this into Pavel's patch? I can keep it
>>> standalone too, just let me know.
>>
>> Fine by me, though I thought Pavel was suggesting keeping it separate:
>> https://lore.kernel.org/io-uring/da109d01-7aab-4205-bbb1-f5f1387f1847@gmail.com/T/#u
>
> I'm reading it as he has other stuff that will go on top. I don't see
> any reason to double stage this part, might as well remove the
> CONFIG dependency at the same time, if it's doable.
>
> Pavel?
I'm not sure why you'd want that, but I don't mind
--
Pavel Begunkov
next prev parent reply other threads:[~2025-02-24 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 17:23 [PATCH] io_uring/waitid: remove #ifdef CONFIG_COMPAT Caleb Sander Mateos
2025-02-24 17:44 ` Jens Axboe
2025-02-24 17:53 ` Caleb Sander Mateos
2025-02-24 17:55 ` Jens Axboe
2025-02-24 19:10 ` Pavel Begunkov [this message]
2025-02-24 19:10 ` Jens Axboe
2025-02-24 19:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91c200cd-2b2d-4756-b641-aa1bd4ec9796@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox