Re: [PATCH] io_uring: update parameter name in io_pin_pages function declaration

[Pavel Begunkov <asml.silence@gmail.com>]

On 4/25/25 12:32, leo.lilong@huaweicloud.com wrote:
> From: Long Li <leo.lilong@huawei.com>
> 
> Fix inconsistent first parameter name in io_pin_pages between declaration
> and implementation. Renamed `ubuf` to `uaddr` for better clarity.
> 
> Fixes: 1943f96b3816 ("io_uring: unify io_pin_pages()")

I'm split on whether such patches make sense, slightly leaning
that they don't, but regardless, why is it a fix and which
problem exactly does it "fix"?

> Signed-off-by: Long Li <leo.lilong@huawei.com>
> ---
>   io_uring/memmap.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io_uring/memmap.h b/io_uring/memmap.h
> index dad0aa5b1b45..b9415a766c26 100644
> --- a/io_uring/memmap.h
> +++ b/io_uring/memmap.h
> @@ -4,7 +4,7 @@
>   #define IORING_MAP_OFF_PARAM_REGION		0x20000000ULL
>   #define IORING_MAP_OFF_ZCRX_REGION		0x30000000ULL
>   
> -struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
> +struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages);
>   
>   #ifndef CONFIG_MMU
>   unsigned int io_uring_nommu_mmap_capabilities(struct file *file);

-- 
Pavel Begunkov