From: Jens Axboe <axboe@kernel.dk>
To: Tony Solomonik <tony.solomonik@gmail.com>
Cc: krisman@suse.de, leitao@debian.org, io-uring@vger.kernel.org,
asml.silence@gmail.com
Subject: Re: [PATCH v2 1/2] Add __do_ftruncate that truncates a struct file*
Date: Tue, 23 Jan 2024 08:40:08 -0700 [thread overview]
Message-ID: <98b98bfb-ccec-49a2-af5c-d5d61c825482@kernel.dk> (raw)
In-Reply-To: <a44444f9-a220-48a3-b282-a26319e2261c@kernel.dk>
On 1/23/24 8:38 AM, Jens Axboe wrote:
>> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
>> index fd9d12de7e92..e8c56986e751 100644
>> --- a/include/linux/syscalls.h
>> +++ b/include/linux/syscalls.h
>> @@ -1229,6 +1229,8 @@ static inline long ksys_lchown(const char __user *filename, uid_t user,
>> AT_SYMLINK_NOFOLLOW);
>> }
>>
>> +extern long __do_ftruncate(struct file *file, loff_t length, int small);
>> +
>> extern long do_sys_ftruncate(unsigned int fd, loff_t length, int small);
>>
>> static inline long ksys_ftruncate(unsigned int fd, loff_t length)
>
> This should go in fs/internal.h, it's not a syscall related thing.
And while at it, let's call it ftruncate_file() as that more accurately
describes what it does.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-23 15:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAD62OrGa9pS6-Qgg_UD4r4d+kCSPQihq0VvtVombrbAAOroG=w@mail.gmail.com>
2024-01-23 11:33 ` [PATCH v2 1/2] Add __do_ftruncate that truncates a struct file* Tony Solomonik
2024-01-23 11:33 ` [PATCH v2 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 15:01 ` Gabriel Krisman Bertazi
2024-01-23 15:36 ` Jens Axboe
2024-01-23 15:46 ` Jens Axboe
2024-01-23 15:50 ` Jens Axboe
2024-01-23 21:19 ` [PATCH v3 0/2] Add ftruncate to io_uring Tony Solomonik
2024-01-23 21:19 ` [PATCH v3 1/2] Add ftruncate_file that truncates a struct file* Tony Solomonik
2024-01-23 22:07 ` Jens Axboe
2024-01-23 21:19 ` [PATCH v3 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 22:11 ` Jens Axboe
2024-01-23 22:33 ` [PATCH v4 0/2] " Tony Solomonik
2024-01-23 22:33 ` [PATCH v4 1/2] Add ftruncate_file that truncates a struct file Tony Solomonik
2024-01-23 22:33 ` [PATCH v4 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 23:24 ` [PATCH v4 0/2] " Jens Axboe
[not found] ` <CAD62OrEC62Ojh+uvMWMb7X=fNZerUVYfUWFmRHQ-49OvTJ1u4Q@mail.gmail.com>
2024-01-23 23:40 ` Jens Axboe
2024-01-23 14:53 ` [PATCH v2 1/2] Add __do_ftruncate that truncates a struct file* Gabriel Krisman Bertazi
2024-01-23 15:38 ` Jens Axboe
2024-01-23 15:40 ` Jens Axboe [this message]
[not found] <20240123112358.78030-1-tony.solomonik@gmail.com>
2024-01-23 11:32 ` Tony Solomonik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b98bfb-ccec-49a2-af5c-d5d61c825482@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=krisman@suse.de \
--cc=leitao@debian.org \
--cc=tony.solomonik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox