From: Jens Axboe <axboe@kernel.dk>
To: "Christian A. Ehrhardt" <lk@c--e.de>
Cc: Tip ten Brink <tip@tenbrinkmeijs.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iouring: Fix min_timeout behaviour
Date: Sat, 6 Jun 2026 15:55:18 -0600 [thread overview]
Message-ID: <9f94f066-ea36-443e-b989-cf920ff9d27e@kernel.dk> (raw)
In-Reply-To: <20260606201120.1441447-1-lk@c--e.de>
On 6/6/26 2:11 PM, Christian A. Ehrhardt wrote:
> The wakeup condition if a min timeout is present and has
> expired is that at least _one_ CQE was posted. Thus set
> the cq_tail target to ->cq_min_tail + 1. Without this
> commit a spurious wakeup can result in a premature wakeup
> because io_should_wake() will return true even if _no_ CQE
> was posted at all.
>
> Tested by running the liburing testsuite with no regressions.
>
> Additionally, tested by turning all calls to schedule() in
> io_uring/wait.c into calls to schedule_timeout(1) to force
> the spurious wakeups. With these spurious wakeups the
> min-timeout.t test fails before and passes after this commit.
Either this or the test case is broken, with or without the change
you sent for the test case. I'll take a look, but it's definitely
not passing as-is.
--
Jens Axboe
next prev parent reply other threads:[~2026-06-06 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 20:11 [PATCH] iouring: Fix min_timeout behaviour Christian A. Ehrhardt
2026-06-06 21:55 ` Jens Axboe [this message]
2026-06-07 10:40 ` Christian A. Ehrhardt
2026-06-07 22:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f94f066-ea36-443e-b989-cf920ff9d27e@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lk@c--e.de \
--cc=tip@tenbrinkmeijs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox