From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79433C433EF for ; Fri, 1 Jul 2022 23:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbiGAXtG (ORCPT ); Fri, 1 Jul 2022 19:49:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbiGAXtG (ORCPT ); Fri, 1 Jul 2022 19:49:06 -0400 Received: from gw2.atmark-techno.com (gw2.atmark-techno.com [35.74.137.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 398583AA6A for ; Fri, 1 Jul 2022 16:49:05 -0700 (PDT) Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by gw2.atmark-techno.com (Postfix) with ESMTPS id 8A15120CEF for ; Sat, 2 Jul 2022 08:49:04 +0900 (JST) Received: by mail-pl1-f197.google.com with SMTP id u13-20020a170902e5cd00b0016a53274671so2129278plf.15 for ; Fri, 01 Jul 2022 16:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LSJ3PXNbjfPuNCs9zB53If0JZ50L8HtGybH/fHIylFg=; b=5/mti0hGsdW6C3ikmPivWh36Bon6mogwAnkcQenoLUXwWQNptbQ8ugeYqsPct44Hez eN/83kI7zyXyPS2PLclAQaeGP6+LZEhcrKFwOs8xNZQvPgPMWEvnP07QnY7YJnSGtAdW HfpOs9cDsM1iuEZE3MLzoPNSMFZt0V7tRnG61mU/Tn4io+BdOV1kkD15Df0VnGPmrBPw 27+KCrppImhMytXzGJXAd0ONQ+g2OD6l4c44+Ufkn3NM82Y4+F+e+ZPDV34G6OwkOtLW DCTCeQD1RZbyN7XSY0ICzqtWwi1B2sWEZK3gOz3sq/OVAMyeNvKMFxHXrEUaJFZMeb0l BjdQ== X-Gm-Message-State: AJIora8vS3fZydg6ncoqjHLxq9ITxwAT0oU6bImIY7cfCMJoPEqV++Lz WBPZyo3aYibWPbyb/NrVgBVYtL21713aOTrnpx/d78l/HejzdqJxjMDgWPJDiai/tbn6JUgcl1/ UukwAZtqiNPXMXA3aeZuj X-Received: by 2002:a17:902:cec9:b0:16a:416c:3d27 with SMTP id d9-20020a170902cec900b0016a416c3d27mr23600849plg.107.1656719343616; Fri, 01 Jul 2022 16:49:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t24xm/saXDVdTU339pirGwPhG1TYMSSgsSiNSXwcWt6iYPii6OI8spYIMjJfkGLSdGcUIVJw== X-Received: by 2002:a17:902:cec9:b0:16a:416c:3d27 with SMTP id d9-20020a170902cec900b0016a416c3d27mr23600832plg.107.1656719343274; Fri, 01 Jul 2022 16:49:03 -0700 (PDT) Received: from pc-zest.atmarktech (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id a3-20020aa780c3000000b0050dc76281f8sm16140626pfn.210.2022.07.01.16.49.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2022 16:49:02 -0700 (PDT) Received: from martinet by pc-zest.atmarktech with local (Exim 4.95) (envelope-from ) id 1o7QNh-001Bed-0v; Sat, 02 Jul 2022 08:49:01 +0900 Date: Sat, 2 Jul 2022 08:48:51 +0900 From: Dominique MARTINET To: Filipe Manana Cc: Nikolay Borisov , Jens Axboe , io-uring@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: read corruption with qemu master io_uring engine / linux master / btrfs(?) Message-ID: References: <20220630104536.GA434846@falcondesktop> <20220630125124.GA446657@falcondesktop> <20220630151038.GA459423@falcondesktop> <20220701084504.GA493565@falcondesktop> <20220701103329.GA503971@falcondesktop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220701103329.GA503971@falcondesktop> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Filipe Manana wrote on Fri, Jul 01, 2022 at 11:33:29AM +0100: > > I'll give it some more testing here along with other minor fixes I have for > > other scenarios. I'll submit a patchset, with this fix included, on monday. > > In the meanwhile, I've left the patches staging here: > > https://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.git/log/?h=dio_fixes Thanks! Just a small typo in commit message for 'return -EAGAIN for NOWAIT' patch: > After having read the first extent, when we find the compressed extent we > eturn -ENOTBLK from btrfs_dio_iomap_begin(), which results in iomap to return at start of second line missing its r rest looks good to me, thank you for the fixes :) -- Dominique