From: Greg KH <greg@kroah.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Lee Jones <lee@kernel.org>,
stable@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5.10 1/1] io_uring: Use original task for req identity in io_identity_cow()
Date: Sat, 23 Jul 2022 15:54:57 +0200 [thread overview]
Message-ID: <Ytv9sdsy9iGcUrVy@kroah.com> (raw)
In-Reply-To: <17dba691-2a2b-4b20-40c3-ec77282179b0@kernel.dk>
On Wed, Jul 20, 2022 at 06:48:09AM -0600, Jens Axboe wrote:
> On 7/19/22 5:52 AM, Lee Jones wrote:
> > This issue is conceptually identical to the one fixed in 29f077d07051
> > ("io_uring: always use original task when preparing req identity"), so
> > rather than reinvent the wheel, I'm shamelessly quoting the commit
> > message from that patch - thanks Jens:
> >
> > "If the ring is setup with IORING_SETUP_IOPOLL and we have more than
> > one task doing submissions on a ring, we can up in a situation where
> > we assign the context from the current task rather than the request
> > originator.
> >
> > Always use req->task rather than assume it's the same as current.
> >
> > No upstream patch exists for this issue, as only older kernels with
> > the non-native workers have this problem."
>
> Greg, can you pick this one up for 5.10-stable? Thanks!
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-07-23 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:52 [PATCH v5.10 1/1] io_uring: Use original task for req identity in io_identity_cow() Lee Jones
2022-07-20 12:48 ` Jens Axboe
2022-07-23 13:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytv9sdsy9iGcUrVy@kroah.com \
--to=greg@kroah.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox