From: Mark Harmstone <maharmstone@meta.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Subject: Re: [PATCH] btrfs: add io_uring interface for encoded reads
Date: Mon, 12 Aug 2024 14:46:24 +0000 [thread overview]
Message-ID: <ac79ec76-200e-44bd-80fc-08ca38c565d0@meta.com> (raw)
In-Reply-To: <Zrnxgu7vkVDgI6VU@infradead.org>
On 12/8/24 12:26, Christoph Hellwig wrote:
> What is the point if this doesn't actually do anything but returning
> -EIOCBQUEUED?
It returns EIOCBQUEUED to say that io_uring has queued the request, and
adds the task to io_uring's thread pool for it to be completed.
> Note that that the internals of the btrfs encoded read is built
> around kiocbs anyway, so you might as well turn things upside down,
> implement a real async io_uring cmd and just wait for it to complete
> to implement the existing synchronous ioctl.
I'd have to look into it, but that sounds like it could be an
interesting future refactor.
Mark
next prev parent reply other threads:[~2024-08-12 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240809173552.929988-1-maharmstone@fb.com>
2024-08-12 11:26 ` [PATCH] btrfs: add io_uring interface for encoded reads Christoph Hellwig
2024-08-12 14:46 ` Mark Harmstone [this message]
2024-08-12 15:03 ` Pavel Begunkov
2024-08-12 16:10 ` Pavel Begunkov
2024-08-12 16:58 ` David Sterba
2024-08-12 19:17 ` Pavel Begunkov
2024-08-13 0:49 ` David Sterba
2024-08-13 1:06 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac79ec76-200e-44bd-80fc-08ca38c565d0@meta.com \
--to=maharmstone@meta.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox