From: Christoph Hellwig <hch@infradead.org>
To: Yi Xie <xieyi@kylinos.cn>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/sync: check unused sqe fields for fallocate
Date: Mon, 20 Jul 2026 01:23:06 -0700 [thread overview]
Message-ID: <al3a6tHCjwulnrog@infradead.org> (raw)
In-Reply-To: <20260717021312.50558-1-xieyi@kylinos.cn>
On Fri, Jul 17, 2026 at 10:13:12AM +0800, Yi Xie wrote:
> Zero check unused SQE fields addr3 and pad2 for fallocate. They're
> not needed now, but could be used sometime in the future.
This is the right thing to do for a newly added command. But
d63d1b5edb7b8 has been around more than 6 years, it's too late now
as old kernels won't have this check, so you can't ever use it for
new features.
prev parent reply other threads:[~2026-07-20 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 2:13 [PATCH] io_uring/sync: check unused sqe fields for fallocate Yi Xie
2026-07-20 8:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3a6tHCjwulnrog@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xieyi@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox