Linux io-uring development
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, Hao-Yu Yang <naup96721@gmail.com>,
	 io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH] io_uring/kbuf: fix use-after-free of new iovec on bundle grow
Date: Tue, 14 Jul 2026 09:00:57 -0700	[thread overview]
Message-ID: <alZc3lIGYKEiomWI@gmail.com> (raw)
In-Reply-To: <87ldbd4qmf.fsf@mailhost.krisman.be>

On Tue, Jul 14, 2026 at 10:01:28AM -0400, Gabriel Krisman Bertazi wrote:
> Breno Leitao <leitao@debian.org> writes:
> 
> > When io_ring_buffers_peek() grows a provided-buffer bundle, it allocates
> > a new iovec array and points arg->iovs at it. The KBUF_MODE_FREE cleanup
> > added at the end of the function then does kfree(arg->iovs), which frees
> > this freshly allocated array that is about to be returned to and used by
> > the caller, instead of the old cached iovec (org_iovs) it was meant to
> > release. The caller reads the now-freed array, resulting in a
> > use-after-free, easily triggered by the liburing recv-bundle-short-ooo
> > test:
> >
> >   BUG: KASAN: slab-use-after-free in io_recv+0x4bc/0xc60
> >   Read of size 8 at addr ffff00037b20c240 by task recv-bundle-sho
> >    io_recv
> >   Allocated by task:
> >    __kmalloc_noprof
> >    io_ring_buffers_peek
> >    io_buffers_peek
> >    io_recv
> >   Freed by task:
> >    kfree
> >    io_ring_buffers_peek
> >    io_buffers_peek
> >    io_recv
> >
> > Free org_iovs instead, and only when it was actually replaced by a new
> > allocation. On the access_ok() failure path the new array is already
> > freed and the request is left pointing at the original iovec, so nothing
> > needs to be released at this point in that case.
> >
> > Fixes: cd053d788c3f ("io_uring: fix dangling iovec after provided-buffer bundle grow failure")
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> 
> Already fixed here
> 
> https://lore.kernel.org/io-uring/20260712142612.188695595-iostreampy@proton.me/T/#u
> 
> here:
> 
> https://lore.kernel.org/io-uring/OS3PR01MB8810F38D613E37FBD684DC4D83FB2@OS3PR01MB8810.jpnprd01.prod.outlook.com/T/#t
> 
> and here:
> 
> https://lore.kernel.org/io-uring/20260713183124.4217-1-doruk@0sec.ai/T/#u

Oh, -ETOOMANY fixes.

> Aren't LLMs fun?

Oh yes, It is easier to send the fix than to check in the mailing list
if someone has fixed it already. 

      reply	other threads:[~2026-07-14 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 12:51 [PATCH] io_uring/kbuf: fix use-after-free of new iovec on bundle grow Breno Leitao
2026-07-14 14:01 ` Gabriel Krisman Bertazi
2026-07-14 16:00   ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alZc3lIGYKEiomWI@gmail.com \
    --to=leitao@debian.org \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=kernel-team@meta.com \
    --cc=krisman@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naup96721@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox