From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Stefan Roesch <shr@devkernel.io>,
Facebook Kernel Team <kernel-team@fb.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Olivier Langlois <olivier@trillion01.com>,
netdev Mailing List <netdev@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC PATCH v2 1/4] liburing: add api to set napi busy poll timeout
Date: Tue, 8 Nov 2022 14:14:56 +0700 [thread overview]
Message-ID: <b507be5c-1669-57ee-d16e-964e326309f9@gnuweeb.org> (raw)
In-Reply-To: <20221107175357.2733763-2-shr@devkernel.io>
On 11/8/22 12:53 AM, Stefan Roesch wrote:
> diff --git a/src/liburing.map b/src/liburing.map
> index 06c64f8..793766e 100644
> --- a/src/liburing.map
> +++ b/src/liburing.map
> @@ -60,6 +60,8 @@ LIBURING_2.3 {
> global:
> io_uring_register_sync_cancel;
> io_uring_register_file_alloc_range;
> + io_uring_register_busy_poll_timeout;
> + io_uring_unregister_busy_poll_timeout;
> io_uring_enter;
> io_uring_enter2;
> io_uring_setup;
> @@ -67,3 +69,9 @@ LIBURING_2.3 {
> io_uring_get_events;
> io_uring_submit_and_get_events;
> } LIBURING_2.2;
I don't understand this part. You add:
io_uring_register_busy_poll_timeout
io_uring_unregister_busy_poll_timeout
in the LIBURING_2.3 section.
What are they? I don't find their declaration and definition.
How do they differ from:
io_uring_napi_register_busy_poll_timeout
io_uring_napi_unregister_busy_poll_timeout
that you add in the LIBURING_2.4 section?
--
Ammar Faizi
next prev parent reply other threads:[~2022-11-08 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:53 [RFC PATCH v2 0/4] liburing: add api for napi busy poll timeout Stefan Roesch
2022-11-07 17:53 ` [RFC PATCH v2 1/4] liburing: add api to set " Stefan Roesch
2022-11-08 7:14 ` Ammar Faizi [this message]
2022-11-07 17:53 ` [RFC PATCH v2 2/4] liburing: add documentation for new napi busy polling Stefan Roesch
2022-11-08 8:04 ` Ammar Faizi
2022-11-07 17:53 ` [RFC PATCH v2 3/4] liburing: add test programs for napi busy poll Stefan Roesch
2022-11-08 7:01 ` Ammar Faizi
2022-11-08 9:47 ` Ammar Faizi
2022-11-07 17:53 ` [RFC PATCH v2 4/4] liburing: update changelog with new feature Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b507be5c-1669-57ee-d16e-964e326309f9@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@trillion01.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox