From: Pavel Begunkov <asml.silence@gmail.com>
To: Olivier Langlois <olivier@trillion01.com>,
Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org
Cc: Lewis Baker <lewissbaker@gmail.com>
Subject: Re: [PATCH] io_uring: add napi busy settings to the fdinfo output
Date: Tue, 30 Jul 2024 16:38:53 +0100 [thread overview]
Message-ID: <b77c6fe1-db33-4fd5-9f0b-67376f75dd54@gmail.com> (raw)
In-Reply-To: <08e5c092-a7c4-47ca-8e4b-44acb741d1f9@gmail.com>
On 7/30/24 16:33, Pavel Begunkov wrote:
> While on the topic of busy polling, there is a function
> io_napi_adjust_timeout(), it ensures that we don't busy poll for longer
> than the passed wait timeout.
>
> Do you use it? I have some doubts in regards to its usefulness, and
> would prefer to try get rid of it if there are no users since it's a
> hustle.
And I need to ask Lewis (CC'ed) the same question (see above).
Looking at
commit 415ce0ea55c5a3afea501a773e002be9ed7149f5
Author: Jens Axboe <axboe@kernel.dk>
Date: Mon Jun 3 13:56:53 2024 -0600
io_uring/napi: fix timeout calculation
https://git.kernel.dk/cgit/linux-block/commit/?id=415ce0ea55c5a3afea501a773e002be9ed7149f5
It sounds like you might be using it.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-07-30 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 22:38 [PATCH] io_uring: add napi busy settings to the fdinfo output Olivier Langlois
2024-07-30 11:05 ` Pavel Begunkov
2024-07-30 14:04 ` Olivier Langlois
2024-07-30 14:08 ` Pavel Begunkov
2024-07-30 14:46 ` Jens Axboe
2024-07-30 12:26 ` Jens Axboe
2024-07-30 15:33 ` Pavel Begunkov
2024-07-30 15:38 ` Pavel Begunkov [this message]
2024-07-30 19:05 ` Olivier Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b77c6fe1-db33-4fd5-9f0b-67376f75dd54@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=lewissbaker@gmail.com \
--cc=olivier@trillion01.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox