Re: [PATCH] liburing: add test for metadata

[Jens Axboe <axboe@kernel.dk>]

On 11/6/25 9:29 PM, Keith Busch wrote:
> +int main(int argc, char *argv[])
> +{
> +	int fd, ret, offset, intervals, metabuffer_size, metabuffer_tx_size;
> +	void *orig_data_buf, *orig_pi_buf, *data_buf;
> +	struct io_uring_sqe *sqe;
> +	struct io_uring_cqe *cqe;
> +	struct io_uring ring;
> +
> +	if (argc < 2) {
> +		fprintf(stderr, "Usage: %s <dev>\n", argv[0]);
> +		return T_EXIT_FAIL;
> +	}

This should be a T_EXIT_SKIP.

> +	fd = open(argv[1], O_RDWR | O_DIRECT);
> +	if (fd < 0) {
> +		perror("Failed to open device with O_DIRECT");
> +		return T_EXIT_FAIL;
> +	}
> +
> +	ret = init_capabilities(fd);
> +	if (ret < 0)
> +		return T_EXIT_FAIL;
> +	if (lba_size == 0 || metadata_size == 0)
> +		return T_EXIT_SKIP;
> +
> +	intervals = DATA_SIZE / lba_size;
> +	metabuffer_tx_size = intervals * metadata_size;
> +	metabuffer_size = metabuffer_tx_size * 2;
> +
> +	if (posix_memalign(&orig_data_buf, pagesize, DATA_SIZE)) {
> +		perror("posix_memalign failed for data buffer");
> +		ret = T_EXIT_FAIL;
> +		goto close;
> +	}
> +
> +	if (posix_memalign(&orig_pi_buf, pagesize, metabuffer_size)) {
> +		perror("posix_memalign failed for metadata buffer");
> +		ret = T_EXIT_FAIL;
> +		goto free;
> +	}
> +
> +	ret = io_uring_queue_init(8, &ring, 0);
> +	if (ret < 0) {
> +		perror("io_uring_queue_init failed");
> +		goto cleanup;
> +	}
> +
> +	data_buf = orig_data_buf;
> +	for (offset = 0; offset < 512; offset++) {
> +		void *pi_buf = (char *)orig_pi_buf + offset * 4;
> +		struct io_uring_attr_pi pi_attr = {
> +			.addr = (__u64)pi_buf,
> +			.seed = offset,
> +			.len = metabuffer_tx_size,
> +		};
> +
> +		if (reftag_enabled)
> +			pi_attr.flags = IO_INTEGRITY_CHK_REFTAG;
> +
> +		init_data(data_buf, offset);
> +		init_metadata(pi_buf, intervals, offset);
> +
> +		sqe = io_uring_get_sqe(&ring);
> +		if (!sqe) {
> +			fprintf(stderr, "Failed to get SQE\n");
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		io_uring_prep_write(sqe, fd, data_buf, DATA_SIZE, offset * lba_size * 8);
> +		io_uring_sqe_set_data(sqe, (void *)1L);
> +
> +		sqe->attr_type_mask = IORING_RW_ATTR_FLAG_PI;
> +		sqe->attr_ptr = (__u64)&pi_attr;
> +
> +		ret = io_uring_submit(&ring);
> +		if (ret < 1) {
> +			perror("io_uring_submit failed (WRITE)");
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		ret = io_uring_wait_cqe(&ring, &cqe);
> +		if (ret < 0) {
> +			perror("io_uring_wait_cqe failed (WRITE)");
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		if (cqe->res < 0) {
> +			fprintf(stderr, "write failed at offset %d: %s\n",
> +				offset, strerror(-cqe->res));
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		io_uring_cqe_seen(&ring, cqe);
> +
> +		memset(data_buf, 0, DATA_SIZE);
> +		memset(pi_buf, 0, metabuffer_tx_size);
> +
> +		sqe = io_uring_get_sqe(&ring);
> +		if (!sqe) {
> +			fprintf(stderr, "failed to get SQE\n");
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		io_uring_prep_read(sqe, fd, data_buf, DATA_SIZE, offset * lba_size * 8);
> +		io_uring_sqe_set_data(sqe, (void *)2L);
> +
> +		sqe->attr_type_mask = IORING_RW_ATTR_FLAG_PI;
> +		sqe->attr_ptr = (__u64)&pi_attr;
> +
> +		ret = io_uring_submit(&ring);
> +		if (ret < 1) {
> +			perror("io_uring_submit failed (read)");
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		ret = io_uring_wait_cqe(&ring, &cqe);
> +		if (ret < 0) {
> +			fprintf(stderr, "io_uring_wait_cqe failed (read): %s\n", strerror(-ret));
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		if (cqe->res < 0) {
> +			fprintf(stderr, "read failed at offset %d: %s\n",
> +				offset, strerror(-cqe->res));
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		ret = check_data(data_buf, offset);
> +		if (ret) {
> +			fprintf(stderr, "data corruption at offset %d\n",
> +				offset);
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		ret = check_metadata(pi_buf, intervals, offset);
> +		if (ret) {
> +			fprintf(stderr, "metadata corruption at offset %d\n",
> +				offset);
> +			ret = T_EXIT_FAIL;
> +			goto ring_exit;
> +		}
> +
> +		io_uring_cqe_seen(&ring, cqe);
> +	}
> +
> +	memset(data_buf, 0, DATA_SIZE);
> +
> +	sqe = io_uring_get_sqe(&ring);
> +	io_uring_prep_write(sqe, fd, data_buf, DATA_SIZE, 0);
> +	io_uring_sqe_set_data(sqe, (void *)1L);
> +
> +	sqe = io_uring_get_sqe(&ring);
> +	io_uring_prep_write(sqe, fd, data_buf, DATA_SIZE, DATA_SIZE);
> +	io_uring_sqe_set_data(sqe, (void *)2L);
> +
> +	io_uring_submit(&ring);
> +
> +	io_uring_wait_cqe(&ring, &cqe);
> +	io_uring_cqe_seen(&ring, cqe);
> +	io_uring_wait_cqe(&ring, &cqe);
> +	io_uring_cqe_seen(&ring, cqe);

This looks a bit odd - no error checking?

-- 
Jens Axboe