Linux io-uring development
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
	syzbot+f7f9c893345c5c615d34@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/1] io_uring/msg_ring: fix overflow posting
Date: Tue, 2 Jul 2024 14:41:14 +0100	[thread overview]
Message-ID: <c148fd4f-01ee-4053-aba2-f89b78cea40c@gmail.com> (raw)
In-Reply-To: <c7350d07fefe8cce32b50f57665edbb6355ea8c1.1719927398.git.asml.silence@gmail.com>

On 7/2/24 14:38, Pavel Begunkov wrote:
> The caller of io_cqring_event_overflow() should be holding the
> completion_lock, which is violated by io_msg_tw_complete. There
> is only one caller of io_add_aux_cqe(), so just add locking there
> for now.

Seems like it can be squashed into the blamed patch
and it's still somewhat on top.

note: msg-ring-overflow.t reproduces it well.

-- 
Pavel Begunkov

  reply	other threads:[~2024-07-02 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 13:38 [PATCH 1/1] io_uring/msg_ring: fix overflow posting Pavel Begunkov
2024-07-02 13:41 ` Pavel Begunkov [this message]
2024-07-02 14:48 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c148fd4f-01ee-4053-aba2-f89b78cea40c@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=syzbot+f7f9c893345c5c615d34@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox